delve/pkg/terminal/command_test.go

1089 lines
31 KiB
Go
Raw Normal View History

package terminal
2014-05-20 21:28:24 +00:00
2014-05-20 23:09:34 +00:00
import (
"flag"
2015-05-04 22:31:13 +00:00
"fmt"
"io/ioutil"
"net"
"net/http"
"os"
"path/filepath"
"regexp"
"runtime"
"strconv"
"strings"
2014-05-20 23:09:34 +00:00
"testing"
"time"
"github.com/go-delve/delve/pkg/config"
"github.com/go-delve/delve/pkg/goversion"
"github.com/go-delve/delve/pkg/logflags"
"github.com/go-delve/delve/pkg/proc/test"
"github.com/go-delve/delve/service"
"github.com/go-delve/delve/service/api"
"github.com/go-delve/delve/service/debugger"
"github.com/go-delve/delve/service/rpc2"
"github.com/go-delve/delve/service/rpccommon"
2014-05-20 23:09:34 +00:00
)
2014-05-20 21:28:24 +00:00
var testBackend, buildMode string
func TestMain(m *testing.M) {
flag.StringVar(&testBackend, "backend", "", "selects backend")
flag.StringVar(&buildMode, "test-buildmode", "", "selects build mode")
var logConf string
flag.StringVar(&logConf, "log", "", "configures logging")
flag.Parse()
test.DefaultTestBackend(&testBackend)
if buildMode != "" && buildMode != "pie" {
fmt.Fprintf(os.Stderr, "unknown build mode %q", buildMode)
os.Exit(1)
}
logflags.Setup(logConf != "", logConf, "")
os.Exit(test.RunTestsWithFixtures(m))
}
type FakeTerminal struct {
2016-02-27 23:02:55 +00:00
*Term
2016-02-29 00:42:48 +00:00
t testing.TB
}
const logCommandOutput = false
2016-02-27 23:02:55 +00:00
func (ft *FakeTerminal) Exec(cmdstr string) (outstr string, err error) {
outfh, err := ioutil.TempFile("", "cmdtestout")
if err != nil {
2016-02-27 23:02:55 +00:00
ft.t.Fatalf("could not create temporary file: %v", err)
}
stdout, stderr, termstdout := os.Stdout, os.Stderr, ft.Term.stdout
os.Stdout, os.Stderr, ft.Term.stdout = outfh, outfh, outfh
defer func() {
os.Stdout, os.Stderr, ft.Term.stdout = stdout, stderr, termstdout
outfh.Close()
outbs, err1 := ioutil.ReadFile(outfh.Name())
if err1 != nil {
2016-02-27 23:02:55 +00:00
ft.t.Fatalf("could not read temporary output file: %v", err)
}
outstr = string(outbs)
if logCommandOutput {
ft.t.Logf("command %q -> %q", cmdstr, outstr)
}
os.Remove(outfh.Name())
}()
err = ft.cmds.Call(cmdstr, ft.Term)
return
}
func (ft *FakeTerminal) ExecStarlark(starlarkProgram string) (outstr string, err error) {
outfh, err := ioutil.TempFile("", "cmdtestout")
if err != nil {
ft.t.Fatalf("could not create temporary file: %v", err)
}
stdout, stderr, termstdout := os.Stdout, os.Stderr, ft.Term.stdout
os.Stdout, os.Stderr, ft.Term.stdout = outfh, outfh, outfh
defer func() {
os.Stdout, os.Stderr, ft.Term.stdout = stdout, stderr, termstdout
outfh.Close()
outbs, err1 := ioutil.ReadFile(outfh.Name())
if err1 != nil {
ft.t.Fatalf("could not read temporary output file: %v", err)
}
outstr = string(outbs)
if logCommandOutput {
ft.t.Logf("command %q -> %q", starlarkProgram, outstr)
}
os.Remove(outfh.Name())
}()
_, err = ft.Term.starlarkEnv.Execute("<stdin>", starlarkProgram, "main", nil)
return
}
2016-02-27 23:02:55 +00:00
func (ft *FakeTerminal) MustExec(cmdstr string) string {
outstr, err := ft.Exec(cmdstr)
if err != nil {
ft.t.Errorf("output of %q: %q", cmdstr, outstr)
2016-02-27 23:02:55 +00:00
ft.t.Fatalf("Error executing <%s>: %v", cmdstr, err)
}
return outstr
}
func (ft *FakeTerminal) MustExecStarlark(starlarkProgram string) string {
outstr, err := ft.ExecStarlark(starlarkProgram)
if err != nil {
ft.t.Errorf("output of %q: %q", starlarkProgram, outstr)
ft.t.Fatalf("Error executing <%s>: %v", starlarkProgram, err)
}
return outstr
}
func (ft *FakeTerminal) AssertExec(cmdstr, tgt string) {
out := ft.MustExec(cmdstr)
if out != tgt {
ft.t.Fatalf("Error executing %q, expected %q got %q", cmdstr, tgt, out)
}
}
func (ft *FakeTerminal) AssertExecError(cmdstr, tgterr string) {
_, err := ft.Exec(cmdstr)
if err == nil {
2016-02-29 00:42:48 +00:00
ft.t.Fatalf("Expected error executing %q", cmdstr)
}
if err.Error() != tgterr {
ft.t.Fatalf("Expected error %q executing %q, got error %q", tgterr, cmdstr, err.Error())
}
}
func withTestTerminal(name string, t testing.TB, fn func(*FakeTerminal)) {
withTestTerminalBuildFlags(name, t, 0, fn)
}
func withTestTerminalBuildFlags(name string, t testing.TB, buildFlags test.BuildFlags, fn func(*FakeTerminal)) {
if testBackend == "rr" {
test.MustHaveRecordingAllowed(t)
}
os.Setenv("TERM", "dumb")
listener, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("couldn't start listener: %s\n", err)
}
defer listener.Close()
if buildMode == "pie" {
buildFlags |= test.BuildModePIE
}
server := rpccommon.NewServer(&service.Config{
Listener: listener,
ProcessArgs: []string{test.BuildFixture(name, buildFlags).Path},
Debugger: debugger.Config{
Backend: testBackend,
},
})
if err := server.Run(); err != nil {
t.Fatal(err)
}
client := rpc2.NewClient(listener.Addr().String())
defer func() {
client.Detach(true)
}()
2016-02-27 23:02:55 +00:00
ft := &FakeTerminal{
2016-02-29 00:42:48 +00:00
t: t,
Term: New(client, &config.Config{}),
2016-02-27 23:02:55 +00:00
}
fn(ft)
}
2014-05-20 21:28:24 +00:00
func TestCommandDefault(t *testing.T) {
var (
cmds = Commands{}
cmd = cmds.Find("non-existant-command", noPrefix)
2014-05-20 21:28:24 +00:00
)
err := cmd(nil, callContext{}, "")
2014-05-20 21:28:24 +00:00
if err == nil {
t.Fatal("cmd() did not default")
}
if err.Error() != "command not available" {
t.Fatal("wrong command output")
}
}
2014-05-20 23:09:34 +00:00
func TestCommandReplayWithoutPreviousCommand(t *testing.T) {
var (
cmds = DebugCommands(nil)
cmd = cmds.Find("", noPrefix)
err = cmd(nil, callContext{}, "")
)
if err != nil {
t.Error("Null command not returned", err)
}
}
func TestCommandThread(t *testing.T) {
var (
cmds = DebugCommands(nil)
cmd = cmds.Find("thread", noPrefix)
)
err := cmd(nil, callContext{}, "")
if err == nil {
t.Fatal("thread terminal command did not default")
}
if err.Error() != "you must specify a thread" {
t.Fatal("wrong command output: ", err.Error())
}
}
func TestExecuteFile(t *testing.T) {
breakCount := 0
traceCount := 0
c := &Commands{
client: nil,
cmds: []command{
{aliases: []string{"trace"}, cmdFn: func(t *Term, ctx callContext, args string) error {
traceCount++
return nil
}},
{aliases: []string{"break"}, cmdFn: func(t *Term, ctx callContext, args string) error {
breakCount++
return nil
}},
},
}
fixturesDir := test.FindFixturesDir()
err := c.executeFile(nil, filepath.Join(fixturesDir, "bpfile"))
if err != nil {
t.Fatalf("executeFile: %v", err)
}
if breakCount != 1 || traceCount != 1 {
t.Fatalf("Wrong counts break: %d trace: %d\n", breakCount, traceCount)
}
}
func TestIssue354(t *testing.T) {
printStack(os.Stdout, []api.Stackframe{}, "", false)
printStack(os.Stdout, []api.Stackframe{
{Location: api.Location{PC: 0, File: "irrelevant.go", Line: 10, Function: nil},
Bottom: true}}, "", false)
}
func TestIssue411(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
test.AllowRecording(t)
withTestTerminal("math", t, func(term *FakeTerminal) {
*: Go 1.14 support branch (#1727) * tests: misc test fixes for go1.14 - math.go is now ambiguous due to changes to the go runtime so specify that we mean our own math.go in _fixtures - go list -m requires vendor-mode to be disabled so pass '-mod=' to it in case user has GOFLAGS=-mod=vendor - update version of go/packages, required to work with go 1.14 (and executed go mod vendor) - Increased goroutine migration in one development version of Go 1.14 revealed a problem with TestCheckpoints in command_test.go and rr_test.go. The tests were always wrong because Restart(checkpoint) doesn't change the current thread but we can't assume that when the checkpoint was taken the current goroutine was running on the same thread. * goversion: update maximum supported version * Makefile: disable testing lldb-server backend on linux with Go 1.14 There seems to be some incompatibility with lldb-server version 6.0.0 on linux and Go 1.14. * proc/gdbserial: better handling of signals - if multiple signals are received simultaneously propagate all of them to the target threads instead of only one. - debugserver will drop an interrupt request if a target thread simultaneously receives a signal, handle this situation. * dwarf/line: normalize backslashes for windows executables Starting with Go 1.14 the compiler sometimes emits backslashes as well as forward slashes in debug_line, normalize everything to / for conformity with the behavior of previous versions. * proc/native: partial support for Windows async preempt mechanism See https://github.com/golang/go/issues/36494 for a description of why full support for 1.14 under windows is problematic. * proc/native: disable Go 1.14 async preemption on Windows See https://github.com/golang/go/issues/36494
2020-02-11 01:31:54 +00:00
term.MustExec("break _fixtures/math.go:8")
term.MustExec("trace _fixtures/math.go:9")
term.MustExec("continue")
out := term.MustExec("next")
if !strings.HasPrefix(out, "> goroutine(1): main.main()") {
t.Fatalf("Wrong output for next: <%s>", out)
}
})
}
func TestTrace(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
test.AllowRecording(t)
withTestTerminal("issue573", t, func(term *FakeTerminal) {
term.MustExec("trace foo")
out, _ := term.Exec("continue")
// The output here is a little strange, but we don't filter stdout vs stderr so it gets jumbled.
// Therefore we assert about the call and return values separately.
if !strings.Contains(out, "> goroutine(1): main.foo(99, 9801)") {
t.Fatalf("Wrong output for tracepoint: %s", out)
}
if !strings.Contains(out, "=> (9900)") {
t.Fatalf("Wrong output for tracepoint return value: %s", out)
}
})
}
func TestTraceWithName(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
test.AllowRecording(t)
withTestTerminal("issue573", t, func(term *FakeTerminal) {
term.MustExec("trace foobar foo")
out, _ := term.Exec("continue")
// The output here is a little strange, but we don't filter stdout vs stderr so it gets jumbled.
// Therefore we assert about the call and return values separately.
if !strings.Contains(out, "> goroutine(1): [foobar] main.foo(99, 9801)") {
t.Fatalf("Wrong output for tracepoint: %s", out)
}
if !strings.Contains(out, "=> (9900)") {
t.Fatalf("Wrong output for tracepoint return value: %s", out)
}
})
}
func TestTraceOnNonFunctionEntry(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
test.AllowRecording(t)
withTestTerminal("issue573", t, func(term *FakeTerminal) {
term.MustExec("trace foobar issue573.go:19")
out, _ := term.Exec("continue")
if !strings.Contains(out, "> goroutine(1): [foobar] main.foo(99, 9801)") {
t.Fatalf("Wrong output for tracepoint: %s", out)
}
if strings.Contains(out, "=> (9900)") {
t.Fatalf("Tracepoint on non-function locspec should not have return value:\n%s", out)
}
})
}
func TestExitStatus(t *testing.T) {
withTestTerminal("continuetestprog", t, func(term *FakeTerminal) {
term.Exec("continue")
status, err := term.handleExit()
if err != nil {
t.Fatal(err)
}
if status != 0 {
t.Fatalf("incorrect exit status, expected 0, got %d", status)
}
})
}
func TestScopePrefix(t *testing.T) {
const goroutinesLinePrefix = " Goroutine "
const goroutinesCurLinePrefix = "* Goroutine "
test.AllowRecording(t)
withTestTerminal("goroutinestackprog", t, func(term *FakeTerminal) {
term.MustExec("b stacktraceme")
term.MustExec("continue")
goroutinesOut := strings.Split(term.MustExec("goroutines"), "\n")
agoroutines := []int{}
nonagoroutines := []int{}
curgid := -1
for _, line := range goroutinesOut {
iscur := strings.HasPrefix(line, goroutinesCurLinePrefix)
if !iscur && !strings.HasPrefix(line, goroutinesLinePrefix) {
continue
}
dash := strings.Index(line, " - ")
if dash < 0 {
continue
}
gid, err := strconv.Atoi(line[len(goroutinesLinePrefix):dash])
if err != nil {
continue
}
if iscur {
curgid = gid
}
if idx := strings.Index(line, " main.agoroutine "); idx < 0 {
nonagoroutines = append(nonagoroutines, gid)
continue
}
agoroutines = append(agoroutines, gid)
}
if len(agoroutines) > 10 {
t.Fatalf("Output of goroutines did not have 10 goroutines stopped on main.agoroutine (%d found): %q", len(agoroutines), goroutinesOut)
}
if len(agoroutines) < 10 {
extraAgoroutines := 0
for _, gid := range nonagoroutines {
stackOut := strings.Split(term.MustExec(fmt.Sprintf("goroutine %d stack", gid)), "\n")
for _, line := range stackOut {
if strings.HasSuffix(line, " main.agoroutine") {
extraAgoroutines++
break
}
}
}
if len(agoroutines)+extraAgoroutines < 10 {
t.Fatalf("Output of goroutines did not have 10 goroutines stopped on main.agoroutine (%d+%d found): %q", len(agoroutines), extraAgoroutines, goroutinesOut)
}
}
if curgid < 0 {
t.Fatalf("Could not find current goroutine in output of goroutines: %q", goroutinesOut)
}
seen := make([]bool, 10)
for _, gid := range agoroutines {
stackOut := strings.Split(term.MustExec(fmt.Sprintf("goroutine %d stack", gid)), "\n")
fid := -1
for _, line := range stackOut {
space := strings.Index(line, " ")
if space < 0 {
continue
}
curfid, err := strconv.Atoi(line[:space])
if err != nil {
continue
}
if idx := strings.Index(line, " main.agoroutine"); idx >= 0 {
fid = curfid
break
}
}
if fid < 0 {
t.Fatalf("Could not find frame for goroutine %d: %v", gid, stackOut)
}
term.AssertExec(fmt.Sprintf("goroutine %d frame %d locals", gid, fid), "(no locals)\n")
argsOut := strings.Split(term.MustExec(fmt.Sprintf("goroutine %d frame %d args", gid, fid)), "\n")
if len(argsOut) != 4 || argsOut[3] != "" {
t.Fatalf("Wrong number of arguments in goroutine %d frame %d: %v", gid, fid, argsOut)
}
out := term.MustExec(fmt.Sprintf("goroutine %d frame %d p i", gid, fid))
ival, err := strconv.Atoi(out[:len(out)-1])
if err != nil {
t.Fatalf("could not parse value %q of i for goroutine %d frame %d: %v", out, gid, fid, err)
}
seen[ival] = true
}
for i := range seen {
if !seen[i] {
t.Fatalf("goroutine %d not found", i)
}
}
term.MustExec("c")
term.AssertExecError("frame", "not enough arguments")
term.AssertExecError(fmt.Sprintf("goroutine %d frame 10 locals", curgid), fmt.Sprintf("Frame 10 does not exist in goroutine %d", curgid))
term.AssertExecError("goroutine 9000 locals", "unknown goroutine 9000")
term.AssertExecError("print n", "could not find symbol value for n")
term.AssertExec("frame 1 print n", "3\n")
term.AssertExec("frame 2 print n", "2\n")
term.AssertExec("frame 3 print n", "1\n")
term.AssertExec("frame 4 print n", "0\n")
term.AssertExecError("frame 5 print n", "could not find symbol value for n")
term.MustExec("frame 2")
term.AssertExec("print n", "2\n")
term.MustExec("frame 4")
term.AssertExec("print n", "0\n")
term.MustExec("down")
term.AssertExec("print n", "1\n")
term.MustExec("down 2")
term.AssertExec("print n", "3\n")
term.AssertExecError("down 2", "Invalid frame -1")
term.AssertExec("print n", "3\n")
term.MustExec("up 2")
term.AssertExec("print n", "1\n")
term.AssertExecError("up 100", "Invalid frame 103")
term.AssertExec("print n", "1\n")
term.MustExec("step")
term.AssertExecError("print n", "could not find symbol value for n")
term.MustExec("frame 2")
term.AssertExec("print n", "2\n")
})
}
func TestOnPrefix(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
if runtime.GOOS == "freebsd" {
t.Skip("test is not valid on FreeBSD")
}
const prefix = "\ti: "
test.AllowRecording(t)
withTestTerminal("goroutinestackprog", t, func(term *FakeTerminal) {
term.MustExec("b agobp main.agoroutine")
term.MustExec("on agobp print i")
seen := make([]bool, 10)
for {
outstr, err := term.Exec("continue")
if err != nil {
if !strings.Contains(err.Error(), "exited") {
t.Fatalf("Unexpected error executing 'continue': %v", err)
}
break
}
out := strings.Split(outstr, "\n")
for i := range out {
if !strings.HasPrefix(out[i], prefix) {
continue
}
id, err := strconv.Atoi(out[i][len(prefix):])
if err != nil {
continue
}
if seen[id] {
t.Fatalf("Goroutine %d seen twice\n", id)
}
seen[id] = true
}
}
for i := range seen {
if !seen[i] {
t.Fatalf("Goroutine %d not seen\n", i)
}
}
})
}
func TestNoVars(t *testing.T) {
test.AllowRecording(t)
withTestTerminal("locationsUpperCase", t, func(term *FakeTerminal) {
term.MustExec("b main.main")
term.MustExec("continue")
term.AssertExec("args", "(no args)\n")
term.AssertExec("locals", "(no locals)\n")
term.AssertExec("vars filterThatMatchesNothing", "(no vars)\n")
})
}
func TestOnPrefixLocals(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
if runtime.GOOS == "freebsd" {
t.Skip("test is not valid on FreeBSD")
}
const prefix = "\ti: "
test.AllowRecording(t)
withTestTerminal("goroutinestackprog", t, func(term *FakeTerminal) {
term.MustExec("b agobp main.agoroutine")
term.MustExec("on agobp args -v")
seen := make([]bool, 10)
for {
outstr, err := term.Exec("continue")
if err != nil {
if !strings.Contains(err.Error(), "exited") {
t.Fatalf("Unexpected error executing 'continue': %v", err)
}
break
}
out := strings.Split(outstr, "\n")
for i := range out {
if !strings.HasPrefix(out[i], prefix) {
continue
}
id, err := strconv.Atoi(out[i][len(prefix):])
if err != nil {
continue
}
if seen[id] {
t.Fatalf("Goroutine %d seen twice\n", id)
}
seen[id] = true
}
}
for i := range seen {
if !seen[i] {
t.Fatalf("Goroutine %d not seen\n", i)
}
}
})
}
func countOccurrences(s, needle string) int {
count := 0
for {
idx := strings.Index(s, needle)
if idx < 0 {
break
}
count++
s = s[idx+len(needle):]
}
return count
}
func TestIssue387(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("test is not valid on ARM64")
}
if runtime.GOOS == "freebsd" {
t.Skip("test is not valid on FreeBSD")
}
// a breakpoint triggering during a 'next' operation will interrupt it
test.AllowRecording(t)
withTestTerminal("issue387", t, func(term *FakeTerminal) {
breakpointHitCount := 0
term.MustExec("break dostuff")
for {
outstr, err := term.Exec("continue")
2018-03-20 10:05:35 +00:00
breakpointHitCount += countOccurrences(outstr, "issue387.go:8")
t.Log(outstr)
if err != nil {
if !strings.Contains(err.Error(), "exited") {
t.Fatalf("Unexpected error executing 'continue': %v", err)
}
break
}
pos := 9
for {
outstr = term.MustExec("next")
2018-03-20 10:05:35 +00:00
breakpointHitCount += countOccurrences(outstr, "issue387.go:8")
t.Log(outstr)
2018-03-20 10:05:35 +00:00
if countOccurrences(outstr, fmt.Sprintf("issue387.go:%d", pos)) == 0 {
t.Fatalf("did not continue to expected position %d", pos)
}
pos++
if pos >= 11 {
break
}
}
}
if breakpointHitCount != 10 {
t.Fatalf("Breakpoint hit wrong number of times, expected 10 got %d", breakpointHitCount)
}
})
}
func listIsAt(t *testing.T, term *FakeTerminal, listcmd string, cur, start, end int) {
outstr := term.MustExec(listcmd)
lines := strings.Split(outstr, "\n")
t.Logf("%q: %q", listcmd, outstr)
if cur >= 0 && !strings.Contains(lines[0], fmt.Sprintf(":%d", cur)) {
t.Fatalf("Could not find current line number in first output line: %q", lines[0])
}
re := regexp.MustCompile(`(=>)?\s+(\d+):`)
outStart, outEnd := 0, 0
for _, line := range lines[1:] {
if line == "" {
continue
}
v := re.FindStringSubmatch(line)
if len(v) != 3 {
continue
}
curline, _ := strconv.Atoi(v[2])
if v[1] == "=>" {
if cur != curline {
t.Fatalf("Wrong current line, got %d expected %d", curline, cur)
}
}
if outStart == 0 {
outStart = curline
}
outEnd = curline
}
if start != -1 || end != -1 {
if outStart != start || outEnd != end {
t.Fatalf("Wrong output range, got %d:%d expected %d:%d", outStart, outEnd, start, end)
}
}
}
func TestListCmd(t *testing.T) {
withTestTerminal("testvariables", t, func(term *FakeTerminal) {
term.MustExec("continue")
term.MustExec("continue")
listIsAt(t, term, "list", 25, 20, 30)
listIsAt(t, term, "list 69", 69, 64, 70)
listIsAt(t, term, "frame 1 list", 62, 57, 67)
listIsAt(t, term, "frame 1 list 69", 69, 64, 70)
_, err := term.Exec("frame 50 list")
if err == nil {
t.Fatalf("Expected error requesting 50th frame")
}
listIsAt(t, term, "list testvariables.go:1", -1, 1, 6)
listIsAt(t, term, "list testvariables.go:10000", -1, 0, 0)
})
}
func TestReverseContinue(t *testing.T) {
test.AllowRecording(t)
if testBackend != "rr" {
return
}
withTestTerminal("continuetestprog", t, func(term *FakeTerminal) {
term.MustExec("break main.main")
term.MustExec("break main.sayhi")
listIsAt(t, term, "continue", 16, -1, -1)
listIsAt(t, term, "continue", 12, -1, -1)
listIsAt(t, term, "rewind", 16, -1, -1)
})
}
func TestCheckpoints(t *testing.T) {
test.AllowRecording(t)
if testBackend != "rr" {
return
}
withTestTerminal("continuetestprog", t, func(term *FakeTerminal) {
term.MustExec("break main.main")
listIsAt(t, term, "continue", 16, -1, -1)
term.MustExec("checkpoint")
term.MustExec("checkpoints")
listIsAt(t, term, "next", 17, -1, -1)
listIsAt(t, term, "next", 18, -1, -1)
*: Go 1.14 support branch (#1727) * tests: misc test fixes for go1.14 - math.go is now ambiguous due to changes to the go runtime so specify that we mean our own math.go in _fixtures - go list -m requires vendor-mode to be disabled so pass '-mod=' to it in case user has GOFLAGS=-mod=vendor - update version of go/packages, required to work with go 1.14 (and executed go mod vendor) - Increased goroutine migration in one development version of Go 1.14 revealed a problem with TestCheckpoints in command_test.go and rr_test.go. The tests were always wrong because Restart(checkpoint) doesn't change the current thread but we can't assume that when the checkpoint was taken the current goroutine was running on the same thread. * goversion: update maximum supported version * Makefile: disable testing lldb-server backend on linux with Go 1.14 There seems to be some incompatibility with lldb-server version 6.0.0 on linux and Go 1.14. * proc/gdbserial: better handling of signals - if multiple signals are received simultaneously propagate all of them to the target threads instead of only one. - debugserver will drop an interrupt request if a target thread simultaneously receives a signal, handle this situation. * dwarf/line: normalize backslashes for windows executables Starting with Go 1.14 the compiler sometimes emits backslashes as well as forward slashes in debug_line, normalize everything to / for conformity with the behavior of previous versions. * proc/native: partial support for Windows async preempt mechanism See https://github.com/golang/go/issues/36494 for a description of why full support for 1.14 under windows is problematic. * proc/native: disable Go 1.14 async preemption on Windows See https://github.com/golang/go/issues/36494
2020-02-11 01:31:54 +00:00
term.MustExec("restart c1")
term.MustExec("goroutine 1")
listIsAt(t, term, "list", 16, -1, -1)
})
}
func TestNextWithCount(t *testing.T) {
test.AllowRecording(t)
withTestTerminal("nextcond", t, func(term *FakeTerminal) {
term.MustExec("break main.main")
listIsAt(t, term, "continue", 8, -1, -1)
listIsAt(t, term, "next 2", 10, -1, -1)
})
}
func TestRestart(t *testing.T) {
withTestTerminal("restartargs", t, func(term *FakeTerminal) {
term.MustExec("break main.printArgs")
term.MustExec("continue")
if out := term.MustExec("print main.args"); !strings.Contains(out, ", []") {
t.Fatalf("wrong args: %q", out)
}
// Reset the arg list
term.MustExec("restart hello")
term.MustExec("continue")
if out := term.MustExec("print main.args"); !strings.Contains(out, ", [\"hello\"]") {
t.Fatalf("wrong args: %q ", out)
}
// Restart w/o arg should retain the current args.
term.MustExec("restart")
term.MustExec("continue")
if out := term.MustExec("print main.args"); !strings.Contains(out, ", [\"hello\"]") {
t.Fatalf("wrong args: %q ", out)
}
// Empty arg list
term.MustExec("restart -noargs")
term.MustExec("continue")
if out := term.MustExec("print main.args"); !strings.Contains(out, ", []") {
t.Fatalf("wrong args: %q ", out)
}
})
}
func TestIssue827(t *testing.T) {
// switching goroutines when the current thread isn't running any goroutine
// causes nil pointer dereference.
withTestTerminal("notify-v2", t, func(term *FakeTerminal) {
go func() {
time.Sleep(1 * time.Second)
http.Get("http://127.0.0.1:8888/test")
time.Sleep(1 * time.Second)
term.client.Halt()
}()
term.MustExec("continue")
term.MustExec("goroutine 1")
})
}
func findCmdName(c *Commands, cmdstr string, prefix cmdPrefix) string {
for _, v := range c.cmds {
if v.match(cmdstr) {
if prefix != noPrefix && v.allowedPrefixes&prefix == 0 {
continue
}
return v.aliases[0]
}
}
return ""
}
func TestConfig(t *testing.T) {
var term Term
term.conf = &config.Config{}
term.cmds = DebugCommands(nil)
err := configureCmd(&term, callContext{}, "nonexistent-parameter 10")
if err == nil {
t.Fatalf("expected error executing configureCmd(nonexistent-parameter)")
}
err = configureCmd(&term, callContext{}, "max-string-len 10")
if err != nil {
t.Fatalf("error executing configureCmd(max-string-len): %v", err)
}
if term.conf.MaxStringLen == nil {
t.Fatalf("expected MaxStringLen 10, got nil")
}
if *term.conf.MaxStringLen != 10 {
t.Fatalf("expected MaxStringLen 10, got: %d", *term.conf.MaxStringLen)
}
err = configureCmd(&term, callContext{}, "show-location-expr true")
if err != nil {
t.Fatalf("error executing configureCmd(show-location-expr true)")
}
if term.conf.ShowLocationExpr != true {
t.Fatalf("expected ShowLocationExpr true, got false")
}
err = configureCmd(&term, callContext{}, "max-variable-recurse 4")
if err != nil {
t.Fatalf("error executing configureCmd(max-variable-recurse): %v", err)
}
if term.conf.MaxVariableRecurse == nil {
t.Fatalf("expected MaxVariableRecurse 4, got nil")
}
if *term.conf.MaxVariableRecurse != 4 {
t.Fatalf("expected MaxVariableRecurse 4, got: %d", *term.conf.MaxVariableRecurse)
}
err = configureCmd(&term, callContext{}, "substitute-path a b")
if err != nil {
t.Fatalf("error executing configureCmd(substitute-path a b): %v", err)
}
if len(term.conf.SubstitutePath) != 1 || (term.conf.SubstitutePath[0] != config.SubstitutePathRule{From: "a", To: "b"}) {
t.Fatalf("unexpected SubstitutePathRules after insert %v", term.conf.SubstitutePath)
}
err = configureCmd(&term, callContext{}, "substitute-path a")
if err != nil {
t.Fatalf("error executing configureCmd(substitute-path a): %v", err)
}
if len(term.conf.SubstitutePath) != 0 {
t.Fatalf("unexpected SubstitutePathRules after delete %v", term.conf.SubstitutePath)
}
err = configureCmd(&term, callContext{}, "alias print blah")
if err != nil {
t.Fatalf("error executing configureCmd(alias print blah): %v", err)
}
if len(term.conf.Aliases["print"]) != 1 {
t.Fatalf("aliases not changed after configure command %v", term.conf.Aliases)
}
if findCmdName(term.cmds, "blah", noPrefix) != "print" {
t.Fatalf("new alias not found")
}
err = configureCmd(&term, callContext{}, "alias blah")
if err != nil {
t.Fatalf("error executing configureCmd(alias blah): %v", err)
}
if len(term.conf.Aliases["print"]) != 0 {
t.Fatalf("alias not removed after configure command %v", term.conf.Aliases)
}
if findCmdName(term.cmds, "blah", noPrefix) != "" {
t.Fatalf("new alias found after delete")
}
}
func TestDisassembleAutogenerated(t *testing.T) {
// Executing the 'disassemble' command on autogenerated code should work correctly
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 13) {
// CL 161337 in Go 1.13 and later removes the autogenerated init function
// https://go-review.googlesource.com/c/go/+/161337
t.Skip("no autogenerated init function in Go 1.13 or later")
}
withTestTerminal("math", t, func(term *FakeTerminal) {
term.MustExec("break main.init")
term.MustExec("continue")
out := term.MustExec("disassemble")
if !strings.Contains(out, "TEXT main.init(SB) ") {
t.Fatalf("output of disassemble wasn't for the main.init function %q", out)
}
})
}
func TestIssue1090(t *testing.T) {
// Exit while executing 'next' should report the "Process exited" error
// message instead of crashing.
withTestTerminal("math", t, func(term *FakeTerminal) {
term.MustExec("break main.main")
term.MustExec("continue")
for {
_, err := term.Exec("next")
if err != nil && strings.Contains(err.Error(), " has exited with status ") {
break
}
}
})
}
func TestPrintContextParkedGoroutine(t *testing.T) {
withTestTerminal("goroutinestackprog", t, func(term *FakeTerminal) {
term.MustExec("break stacktraceme")
term.MustExec("continue")
// pick a goroutine that isn't running on a thread
gid := ""
gout := strings.Split(term.MustExec("goroutines"), "\n")
t.Logf("goroutines -> %q", gout)
for _, gline := range gout {
if !strings.Contains(gline, "thread ") && strings.Contains(gline, "agoroutine") {
if dash := strings.Index(gline, " - "); dash > 0 {
gid = gline[len(" Goroutine "):dash]
break
}
}
}
t.Logf("picked %q", gid)
term.MustExec(fmt.Sprintf("goroutine %s", gid))
frameout := strings.Split(term.MustExec("frame 0"), "\n")
t.Logf("frame 0 -> %q", frameout)
if strings.Contains(frameout[0], "stacktraceme") {
t.Fatal("bad output for `frame 0` command on a parked goorutine")
}
listout := strings.Split(term.MustExec("list"), "\n")
t.Logf("list -> %q", listout)
if strings.Contains(listout[0], "stacktraceme") {
t.Fatal("bad output for list command on a parked goroutine")
}
})
}
func TestStepOutReturn(t *testing.T) {
ver, _ := goversion.Parse(runtime.Version())
if ver.Major >= 0 && !ver.AfterOrEqual(goversion.GoVersion{Major: 1, Minor: 10, Rev: -1}) {
t.Skip("return variables aren't marked on 1.9 or earlier")
}
withTestTerminal("stepoutret", t, func(term *FakeTerminal) {
term.MustExec("break main.stepout")
term.MustExec("continue")
out := term.MustExec("stepout")
t.Logf("output: %q", out)
if !strings.Contains(out, "num: ") || !strings.Contains(out, "str: ") {
t.Fatal("could not find parameter")
}
})
}
func TestOptimizationCheck(t *testing.T) {
withTestTerminal("continuetestprog", t, func(term *FakeTerminal) {
term.MustExec("break main.main")
out := term.MustExec("continue")
t.Logf("output %q", out)
if strings.Contains(out, optimizedFunctionWarning) {
t.Fatal("optimized function warning")
}
})
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 10) {
withTestTerminalBuildFlags("continuetestprog", t, test.EnableOptimization|test.EnableInlining, func(term *FakeTerminal) {
term.MustExec("break main.main")
out := term.MustExec("continue")
t.Logf("output %q", out)
if !strings.Contains(out, optimizedFunctionWarning) {
t.Fatal("optimized function warning missing")
}
})
}
}
func TestTruncateStacktrace(t *testing.T) {
withTestTerminal("stacktraceprog", t, func(term *FakeTerminal) {
term.MustExec("break main.stacktraceme")
term.MustExec("continue")
out1 := term.MustExec("stack")
t.Logf("untruncated output %q", out1)
if strings.Contains(out1, stacktraceTruncatedMessage) {
t.Fatalf("stacktrace was truncated")
}
out2 := term.MustExec("stack 1")
t.Logf("truncated output %q", out2)
if !strings.Contains(out2, stacktraceTruncatedMessage) {
t.Fatalf("stacktrace was not truncated")
}
})
}
func TestIssue1493(t *testing.T) {
if runtime.GOARCH == "arm64" {
t.Skip("arm64 does not support FpRegs for now")
}
// The 'regs' command without the '-a' option should only return
// general purpose registers.
withTestTerminal("continuetestprog", t, func(term *FakeTerminal) {
r := term.MustExec("regs")
nr := len(strings.Split(r, "\n"))
t.Logf("regs: %s", r)
ra := term.MustExec("regs -a")
nra := len(strings.Split(ra, "\n"))
t.Logf("regs -a: %s", ra)
if nr > nra/2+1 {
t.Fatalf("'regs' returned too many registers (%d) compared to 'regs -a' (%d)", nr, nra)
}
})
}
func findStarFile(name string) string {
return filepath.Join(test.FindFixturesDir(), name+".star")
}
func TestIssue1598(t *testing.T) {
if runtime.GOARCH == "arm64" || runtime.GOARCH == "386" {
t.Skip(fmt.Errorf("%s does not support FunctionCall for now", runtime.GOARCH))
}
test.MustSupportFunctionCalls(t, testBackend)
withTestTerminal("issue1598", t, func(term *FakeTerminal) {
term.MustExec("break issue1598.go:5")
term.MustExec("continue")
term.MustExec("config max-string-len 500")
r := term.MustExec("call x()")
t.Logf("result %q", r)
if !strings.Contains(r, "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut \\nlabore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut") {
t.Fatalf("wrong value returned")
}
})
}
func TestExamineMemoryCmd(t *testing.T) {
withTestTerminal("examinememory", t, func(term *FakeTerminal) {
term.MustExec("break examinememory.go:19")
term.MustExec("break examinememory.go:24")
term.MustExec("continue")
addressStr := strings.TrimSpace(term.MustExec("p bspUintptr"))
address, err := strconv.ParseInt(addressStr, 0, 64)
if err != nil {
t.Fatalf("could convert %s into int64, err %s", addressStr, err)
}
res := term.MustExec("examinemem -len 52 -fmt hex " + addressStr)
t.Logf("the result of examining memory \n%s", res)
// check first line
firstLine := fmt.Sprintf("%#x: 0x0a 0x0b 0x0c 0x0d 0x0e 0x0f 0x10 0x11", address)
if !strings.Contains(res, firstLine) {
t.Fatalf("expected first line: %s", firstLine)
}
// check last line
lastLine := fmt.Sprintf("%#x: 0x3a 0x3b 0x3c 0x00", address+6*8)
if !strings.Contains(res, lastLine) {
t.Fatalf("expected last line: %s", lastLine)
}
// second examining memory
term.MustExec("continue")
res = term.MustExec("x -len 52 -fmt bin " + addressStr)
t.Logf("the second result of examining memory result \n%s", res)
// check first line
firstLine = fmt.Sprintf("%#x: 11111111 00001011 00001100 00001101", address)
if !strings.Contains(res, firstLine) {
t.Fatalf("expected first line: %s", firstLine)
}
})
}
func TestPrintOnTracepoint(t *testing.T) {
withTestTerminal("increment", t, func(term *FakeTerminal) {
term.MustExec("trace main.Increment")
term.MustExec("on 1 print y+1")
out, _ := term.Exec("continue")
if !strings.Contains(out, "y+1: 4") || !strings.Contains(out, "y+1: 2") || !strings.Contains(out, "y+1: 1") {
t.Errorf("output did not contain breakpoint information: %q", out)
}
})
}