2018-04-18 07:36:40 +00:00
package main_test
2016-09-25 15:26:59 +00:00
import (
"bufio"
2017-07-26 18:51:44 +00:00
"bytes"
2017-02-10 14:11:40 +00:00
"flag"
2017-07-26 18:51:44 +00:00
"fmt"
2018-11-20 15:13:09 +00:00
"go/ast"
"go/token"
"go/types"
2020-02-28 17:48:59 +00:00
"io"
2017-07-26 18:51:44 +00:00
"io/ioutil"
2021-10-13 18:43:47 +00:00
"net"
2016-09-25 15:26:59 +00:00
"os"
"os/exec"
2021-08-24 12:53:27 +00:00
"os/user"
2016-09-25 15:26:59 +00:00
"path/filepath"
"runtime"
2018-11-20 15:13:09 +00:00
"strconv"
2017-03-13 17:59:34 +00:00
"strings"
2016-09-25 15:26:59 +00:00
"testing"
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
"time"
2016-09-25 15:26:59 +00:00
2021-08-24 12:53:27 +00:00
"github.com/go-delve/delve/pkg/goversion"
2019-01-04 18:39:25 +00:00
protest "github.com/go-delve/delve/pkg/proc/test"
"github.com/go-delve/delve/pkg/terminal"
2021-10-25 19:39:28 +00:00
"github.com/go-delve/delve/service/dap"
2020-02-28 17:48:59 +00:00
"github.com/go-delve/delve/service/dap/daptest"
2022-04-01 17:31:03 +00:00
"github.com/go-delve/delve/service/debugger"
2019-01-04 18:39:25 +00:00
"github.com/go-delve/delve/service/rpc2"
2021-10-25 19:39:28 +00:00
godap "github.com/google/go-dap"
2018-11-20 15:13:09 +00:00
"golang.org/x/tools/go/packages"
2016-09-25 15:26:59 +00:00
)
2017-02-10 14:11:40 +00:00
var testBackend string
2021-08-24 12:53:27 +00:00
var ldFlags string
func init ( ) {
ldFlags = os . Getenv ( "CGO_LDFLAGS" )
}
2017-02-10 14:11:40 +00:00
func TestMain ( m * testing . M ) {
flag . StringVar ( & testBackend , "backend" , "" , "selects backend" )
flag . Parse ( )
if testBackend == "" {
testBackend = os . Getenv ( "PROCTEST" )
if testBackend == "" {
testBackend = "native"
2018-11-12 22:52:13 +00:00
if runtime . GOOS == "darwin" {
testBackend = "lldb"
}
2017-02-10 14:11:40 +00:00
}
}
2020-05-14 12:23:16 +00:00
os . Exit ( protest . RunTestsWithFixtures ( m ) )
2017-02-10 14:11:40 +00:00
}
2016-09-25 15:26:59 +00:00
func assertNoError ( err error , t testing . TB , s string ) {
2021-10-25 19:39:28 +00:00
t . Helper ( )
2016-09-25 15:26:59 +00:00
if err != nil {
_ , file , line , _ := runtime . Caller ( 1 )
fname := filepath . Base ( file )
t . Fatalf ( "failed assertion at %s:%d: %s - %s\n" , fname , line , s , err )
}
}
2018-11-13 00:22:53 +00:00
func projectRoot ( ) string {
wd , err := os . Getwd ( )
if err != nil {
panic ( err )
2017-03-13 17:59:34 +00:00
}
2018-11-28 18:22:11 +00:00
gopaths := strings . FieldsFunc ( os . Getenv ( "GOPATH" ) , func ( r rune ) bool { return r == os . PathListSeparator } )
for _ , curpath := range gopaths {
// Detects "gopath mode" when GOPATH contains several paths ex. "d:\\dir\\gopath;f:\\dir\\gopath2"
if strings . Contains ( wd , curpath ) {
2019-01-04 18:39:25 +00:00
return filepath . Join ( curpath , "src" , "github.com" , "go-delve" , "delve" )
2018-11-28 18:22:11 +00:00
}
2018-11-13 00:22:53 +00:00
}
2020-02-11 01:31:54 +00:00
val , err := exec . Command ( "go" , "list" , "-mod=" , "-m" , "-f" , "{{ .Dir }}" ) . Output ( )
2017-03-13 17:59:34 +00:00
if err != nil {
panic ( err ) // the Go tool was tested to work earlier
}
2018-11-13 00:22:53 +00:00
return strings . TrimSuffix ( string ( val ) , "\n" )
2017-03-13 17:59:34 +00:00
}
2016-09-25 15:26:59 +00:00
func TestBuild ( t * testing . T ) {
2019-07-30 15:38:25 +00:00
const listenAddr = "127.0.0.1:40573"
2016-11-18 07:21:50 +00:00
var err error
2018-05-28 18:28:39 +00:00
2020-03-28 18:18:55 +00:00
cmd := exec . Command ( "go" , "run" , "_scripts/make.go" , "build" )
2018-11-13 00:22:53 +00:00
cmd . Dir = projectRoot ( )
2018-05-28 18:28:39 +00:00
out , err := cmd . CombinedOutput ( )
if err != nil {
t . Fatalf ( "makefile error: %v\noutput %s\n" , err , string ( out ) )
2016-11-18 07:21:50 +00:00
}
2018-05-28 18:28:39 +00:00
dlvbin := filepath . Join ( cmd . Dir , "dlv" )
2016-09-25 15:26:59 +00:00
defer os . Remove ( dlvbin )
fixtures := protest . FindFixturesDir ( )
buildtestdir := filepath . Join ( fixtures , "buildtest" )
2018-05-28 18:28:39 +00:00
cmd = exec . Command ( dlvbin , "debug" , "--headless=true" , "--listen=" + listenAddr , "--api-version=2" , "--backend=" + testBackend , "--log" , "--log-output=debugger,rpc" )
2016-09-25 15:26:59 +00:00
cmd . Dir = buildtestdir
2018-06-14 18:12:11 +00:00
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
2020-10-19 21:44:04 +00:00
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "dlv debug" )
2016-09-25 15:26:59 +00:00
2018-06-14 18:12:11 +00:00
scan := bufio . NewScanner ( stderr )
2016-09-25 15:26:59 +00:00
// wait for the debugger to start
scan . Scan ( )
2018-11-12 22:52:13 +00:00
t . Log ( scan . Text ( ) )
2016-09-25 15:26:59 +00:00
go func ( ) {
for scan . Scan ( ) {
2018-11-12 22:52:13 +00:00
t . Log ( scan . Text ( ) )
2016-09-25 15:26:59 +00:00
// keep pipe empty
}
} ( )
client := rpc2 . NewClient ( listenAddr )
state := <- client . Continue ( )
if ! state . Exited {
t . Fatal ( "Program did not exit" )
}
2017-06-26 18:45:13 +00:00
client . Detach ( true )
cmd . Wait ( )
2016-09-25 15:26:59 +00:00
}
2017-07-26 18:51:44 +00:00
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
func testOutput ( t * testing . T , dlvbin , output string , delveCmds [ ] string ) ( stdout , stderr [ ] byte ) {
2017-07-26 18:51:44 +00:00
var stdoutBuf , stderrBuf bytes . Buffer
buildtestdir := filepath . Join ( protest . FindFixturesDir ( ) , "buildtest" )
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
2020-08-21 14:14:02 +00:00
c := [ ] string { dlvbin , "debug" , "--allow-non-terminal-interactive=true" }
2019-05-31 17:26:19 +00:00
debugbin := filepath . Join ( buildtestdir , "__debug_bin" )
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
if output != "" {
c = append ( c , "--output" , output )
if filepath . IsAbs ( output ) {
debugbin = output
} else {
debugbin = filepath . Join ( buildtestdir , output )
}
}
cmd := exec . Command ( c [ 0 ] , c [ 1 : ] ... )
2017-07-26 18:51:44 +00:00
cmd . Dir = buildtestdir
stdin , err := cmd . StdinPipe ( )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "stdin pipe" )
defer stdin . Close ( )
2017-07-26 18:51:44 +00:00
cmd . Stdout = & stdoutBuf
cmd . Stderr = & stderrBuf
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
2020-10-19 21:44:04 +00:00
assertNoError ( cmd . Start ( ) , t , "dlv debug with output" )
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
// Give delve some time to compile and write the binary.
foundIt := false
for wait := 0 ; wait < 30 ; wait ++ {
_ , err = os . Stat ( debugbin )
if err == nil {
foundIt = true
break
}
time . Sleep ( 1 * time . Second )
}
if ! foundIt {
t . Errorf ( "running %q: file not created: %v" , delveCmds , err )
}
for _ , c := range delveCmds {
2017-07-26 18:51:44 +00:00
fmt . Fprintf ( stdin , "%s\n" , c )
}
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
2017-07-26 18:51:44 +00:00
// ignore "dlv debug" command error, it returns
// errors even after successful debug session.
cmd . Wait ( )
stdout , stderr = stdoutBuf . Bytes ( ) , stderrBuf . Bytes ( )
_ , err = os . Stat ( debugbin )
if err == nil {
2021-02-21 19:17:14 +00:00
// Sometimes delve on Windows can't remove the built binary before
// exiting and gets an "Access is denied" error when trying.
2021-03-15 16:34:26 +00:00
// See: https://travis-ci.com/go-delve/delve/jobs/296325131)
// We have added a delay to gobuild.Remove, but to avoid any test
// flakiness, we guard against this failure here as well.
if runtime . GOOS != "windows" || ! strings . Contains ( err . Error ( ) , "Access is denied" ) {
t . Errorf ( "running %q: file %v was not deleted\nstdout is %q, stderr is %q" , delveCmds , debugbin , stdout , stderr )
}
2017-07-26 18:51:44 +00:00
return
}
if ! os . IsNotExist ( err ) {
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
t . Errorf ( "running %q: %v\nstdout is %q, stderr is %q" , delveCmds , err , stdout , stderr )
2017-07-26 18:51:44 +00:00
return
}
return
}
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
func getDlvBin ( t * testing . T ) ( string , string ) {
2021-08-24 12:53:27 +00:00
// In case this was set in the environment
// from getDlvBinEBPF lets clear it here so
// we can ensure we don't get build errors
// depending on the test ordering.
os . Setenv ( "CGO_LDFLAGS" , ldFlags )
return getDlvBinInternal ( t )
}
func getDlvBinEBPF ( t * testing . T ) ( string , string ) {
return getDlvBinInternal ( t , "-tags" , "ebpf" )
}
func getDlvBinInternal ( t * testing . T , goflags ... string ) ( string , string ) {
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
tmpdir , err := ioutil . TempDir ( "" , "TestDlv" )
2017-07-26 18:51:44 +00:00
if err != nil {
t . Fatal ( err )
}
dlvbin := filepath . Join ( tmpdir , "dlv.exe" )
2021-08-24 12:53:27 +00:00
args := append ( [ ] string { "build" , "-o" , dlvbin } , goflags ... )
args = append ( args , "github.com/go-delve/delve/cmd/dlv" )
out , err := exec . Command ( "go" , args ... ) . CombinedOutput ( )
2017-07-26 18:51:44 +00:00
if err != nil {
2019-01-04 18:39:25 +00:00
t . Fatalf ( "go build -o %v github.com/go-delve/delve/cmd/dlv: %v\n%s" , dlvbin , err , string ( out ) )
2017-07-26 18:51:44 +00:00
}
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
return dlvbin , tmpdir
}
// TestOutput verifies that the debug executable is created in the correct path
// and removed after exit.
func TestOutput ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
2017-07-26 18:51:44 +00:00
Support --output for debug, trace, and test commands (#1028)
* Support --output for debug, trace, and test commands
With the `--output` parameter you can configure the output binary. For
example:
dlv debug --output /tmp/xxx
Will build the binary to `/tmp/xxx`, instead of always putting it as
`debug` in the current directory.
This ensures that the command always works (even if there is already a
file or directory named `debug`) and doesn't write to the source
directory. Especially for things like Delve/Vim integration this is a
good thing to have, I think.
* Address PR feedback and add a test
- We don't need to use `filepath.IsAbs()` on startup; I added that
because it previously did `"./" + debugname` everywhere, but I don't
think that's needed at all, since `pathname` without a leading `./`
implies the current directory.
- Repurpose the existing `TestIssue398` to also test the `--output`
flag. Also fix an issue where tests wouldn't work if `GOPATH` has
multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
- Print an error if we can't remove the debug binary on exit instead of
failing silently. Not strictly related to this PR, but a good change
to add I think.
* Also warn when delve can't remove the binary in test/trace
I only added that to debug, but good to issue this warning consistently.
2017-11-28 18:51:30 +00:00
for _ , output := range [ ] string { "" , "myownname" , filepath . Join ( tmpdir , "absolute.path" ) } {
testOutput ( t , dlvbin , output , [ ] string { "exit" } )
const hello = "hello world!"
stdout , _ := testOutput ( t , dlvbin , output , [ ] string { "continue" , "exit" } )
if ! strings . Contains ( string ( stdout ) , hello ) {
t . Errorf ( "stdout %q should contain %q" , stdout , hello )
}
2017-07-26 18:51:44 +00:00
}
}
2018-04-18 07:36:40 +00:00
2019-07-19 17:59:38 +00:00
// TestContinue verifies that the debugged executable starts immediately with --continue
func TestContinue ( t * testing . T ) {
2019-07-30 15:38:25 +00:00
const listenAddr = "127.0.0.1:40573"
2019-07-19 17:59:38 +00:00
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
buildtestdir := filepath . Join ( protest . FindFixturesDir ( ) , "buildtest" )
cmd := exec . Command ( dlvbin , "debug" , "--headless" , "--continue" , "--accept-multiclient" , "--listen" , listenAddr )
cmd . Dir = buildtestdir
stdout , err := cmd . StdoutPipe ( )
2021-09-01 17:31:37 +00:00
assertNoError ( err , t , "stdout pipe" )
2020-10-19 21:44:04 +00:00
defer stdout . Close ( )
assertNoError ( cmd . Start ( ) , t , "start headless instance" )
2019-07-19 17:59:38 +00:00
scan := bufio . NewScanner ( stdout )
// wait for the debugger to start
for scan . Scan ( ) {
t . Log ( scan . Text ( ) )
if scan . Text ( ) == "hello world!" {
break
2019-08-01 23:28:38 +00:00
}
2019-07-19 17:59:38 +00:00
}
// and detach from and kill the headless instance
client := rpc2 . NewClient ( listenAddr )
if err := client . Detach ( true ) ; err != nil {
t . Fatalf ( "error detaching from headless instance: %v" , err )
}
cmd . Wait ( )
}
2020-05-14 12:23:16 +00:00
// TestChildProcessExitWhenNoDebugInfo verifies that the child process exits when dlv launch the binary without debug info
func TestChildProcessExitWhenNoDebugInfo ( t * testing . T ) {
2022-04-01 17:31:23 +00:00
noDebugFlags := protest . LinkStrip
// -s doesn't strip symbols on Mac, use -w instead
2020-05-14 12:23:16 +00:00
if runtime . GOOS == "darwin" {
2022-04-01 17:31:23 +00:00
noDebugFlags = protest . LinkDisableDWARF
2020-05-14 12:23:16 +00:00
}
if _ , err := exec . LookPath ( "ps" ) ; err != nil {
t . Skip ( "test skipped, `ps` not found" )
}
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
2022-04-01 17:31:23 +00:00
fix := protest . BuildFixture ( "http_server" , noDebugFlags )
2020-05-14 12:23:16 +00:00
// dlv exec the binary file and expect error.
2022-03-29 18:01:04 +00:00
out , err := exec . Command ( dlvbin , "exec" , "--headless" , "--log" , fix . Path ) . CombinedOutput ( )
t . Log ( string ( out ) )
if err == nil {
2020-05-14 12:23:16 +00:00
t . Fatalf ( "Expected err when launching the binary without debug info, but got nil" )
}
2022-03-29 18:01:04 +00:00
// Test only for dlv's prefix of the error like "could not launch process: could not open debug info"
2022-04-01 17:31:03 +00:00
if ! strings . Contains ( string ( out ) , "could not launch process" ) || ! strings . Contains ( string ( out ) , debugger . NoDebugWarning ) {
t . Fatalf ( "Expected logged error 'could not launch process: ... - %s'" , debugger . NoDebugWarning )
2022-03-29 18:01:04 +00:00
}
2020-05-14 12:23:16 +00:00
// search the running process named fix.Name
cmd := exec . Command ( "ps" , "-aux" )
stdout , err := cmd . StdoutPipe ( )
2021-09-01 17:31:37 +00:00
assertNoError ( err , t , "stdout pipe" )
2020-10-19 21:44:04 +00:00
defer stdout . Close ( )
assertNoError ( cmd . Start ( ) , t , "start `ps -aux`" )
2020-05-14 12:23:16 +00:00
var foundFlag bool
scan := bufio . NewScanner ( stdout )
for scan . Scan ( ) {
t . Log ( scan . Text ( ) )
if strings . Contains ( scan . Text ( ) , fix . Name ) {
foundFlag = true
break
}
}
cmd . Wait ( )
if foundFlag {
t . Fatalf ( "Expected child process exited, but found it running" )
}
}
2020-11-09 08:31:12 +00:00
// TestRedirect verifies that redirecting stdin works
func TestRedirect ( t * testing . T ) {
const listenAddr = "127.0.0.1:40573"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
catfixture := filepath . Join ( protest . FindFixturesDir ( ) , "cat.go" )
cmd := exec . Command ( dlvbin , "debug" , "--headless" , "--continue" , "--accept-multiclient" , "--listen" , listenAddr , "-r" , catfixture , catfixture )
stdout , err := cmd . StdoutPipe ( )
2021-09-01 17:31:37 +00:00
assertNoError ( err , t , "stdout pipe" )
2020-11-09 08:31:12 +00:00
defer stdout . Close ( )
assertNoError ( cmd . Start ( ) , t , "start headless instance" )
scan := bufio . NewScanner ( stdout )
// wait for the debugger to start
for scan . Scan ( ) {
t . Log ( scan . Text ( ) )
if scan . Text ( ) == "read \"}\"" {
break
}
}
// and detach from and kill the headless instance
client := rpc2 . NewClient ( listenAddr )
2021-01-05 18:59:17 +00:00
_ = client . Detach ( true )
2020-11-09 08:31:12 +00:00
cmd . Wait ( )
}
2021-07-01 18:25:33 +00:00
const checkAutogenDocLongOutput = false
2018-04-18 07:36:40 +00:00
func checkAutogenDoc ( t * testing . T , filename , gencommand string , generated [ ] byte ) {
2018-11-13 00:22:53 +00:00
saved := slurpFile ( t , filepath . Join ( projectRoot ( ) , filename ) )
2018-04-18 07:36:40 +00:00
2021-01-20 17:40:03 +00:00
saved = bytes . ReplaceAll ( saved , [ ] byte ( "\r\n" ) , [ ] byte { '\n' } )
generated = bytes . ReplaceAll ( generated , [ ] byte ( "\r\n" ) , [ ] byte { '\n' } )
2018-04-18 07:36:40 +00:00
if len ( saved ) != len ( generated ) {
2021-07-01 18:25:33 +00:00
if checkAutogenDocLongOutput {
t . Logf ( "generated %q saved %q\n" , generated , saved )
}
2021-09-24 22:31:54 +00:00
diffMaybe ( t , filename , generated )
2018-04-19 08:43:23 +00:00
t . Fatalf ( "%s: needs to be regenerated; run %s" , filename , gencommand )
2018-04-18 07:36:40 +00:00
}
for i := range saved {
if saved [ i ] != generated [ i ] {
2021-07-01 18:25:33 +00:00
if checkAutogenDocLongOutput {
t . Logf ( "generated %q saved %q\n" , generated , saved )
}
2021-09-24 22:31:54 +00:00
diffMaybe ( t , filename , generated )
2018-04-18 07:36:40 +00:00
t . Fatalf ( "%s: needs to be regenerated; run %s" , filename , gencommand )
}
}
}
func slurpFile ( t * testing . T , filename string ) [ ] byte {
saved , err := ioutil . ReadFile ( filename )
if err != nil {
t . Fatalf ( "Could not read %s: %v" , filename , err )
}
return saved
}
2021-09-24 22:31:54 +00:00
func diffMaybe ( t * testing . T , filename string , generated [ ] byte ) {
_ , err := exec . LookPath ( "diff" )
if err != nil {
return
}
cmd := exec . Command ( "diff" , filename , "-" )
cmd . Dir = projectRoot ( )
stdin , _ := cmd . StdinPipe ( )
go func ( ) {
stdin . Write ( generated )
stdin . Close ( )
} ( )
out , _ := cmd . CombinedOutput ( )
t . Logf ( "diff:\n%s" , string ( out ) )
}
2018-04-18 07:36:40 +00:00
// TestGeneratedDoc tests that the autogenerated documentation has been
// updated.
func TestGeneratedDoc ( t * testing . T ) {
2020-03-13 13:14:32 +00:00
if strings . ToLower ( os . Getenv ( "TRAVIS" ) ) == "true" && runtime . GOOS == "windows" {
t . Skip ( "skipping test on Windows in CI" )
}
2018-04-18 07:36:40 +00:00
// Checks gen-cli-docs.go
var generatedBuf bytes . Buffer
commands := terminal . DebugCommands ( nil )
commands . WriteMarkdown ( & generatedBuf )
2020-03-28 18:18:55 +00:00
checkAutogenDoc ( t , "Documentation/cli/README.md" , "_scripts/gen-cli-docs.go" , generatedBuf . Bytes ( ) )
2018-04-18 07:36:40 +00:00
// Checks gen-usage-docs.go
tempDir , err := ioutil . TempDir ( os . TempDir ( ) , "test-gen-doc" )
assertNoError ( err , t , "TempDir" )
2019-10-21 18:48:04 +00:00
defer protest . SafeRemoveAll ( tempDir )
2020-03-28 18:18:55 +00:00
cmd := exec . Command ( "go" , "run" , "_scripts/gen-usage-docs.go" , tempDir )
2019-10-07 16:20:49 +00:00
cmd . Dir = projectRoot ( )
2020-05-04 17:00:33 +00:00
err = cmd . Run ( )
assertNoError ( err , t , "go run _scripts/gen-usage-docs.go" )
2018-04-18 07:36:40 +00:00
entries , err := ioutil . ReadDir ( tempDir )
assertNoError ( err , t , "ReadDir" )
for _ , doc := range entries {
docFilename := "Documentation/usage/" + doc . Name ( )
2020-03-28 18:18:55 +00:00
checkAutogenDoc ( t , docFilename , "_scripts/gen-usage-docs.go" , slurpFile ( t , tempDir + "/" + doc . Name ( ) ) )
2018-04-18 07:36:40 +00:00
}
2019-07-02 17:55:27 +00:00
runScript := func ( args ... string ) [ ] byte {
a := [ ] string { "run" }
a = append ( a , args ... )
cmd := exec . Command ( "go" , a ... )
cmd . Dir = projectRoot ( )
out , err := cmd . CombinedOutput ( )
if err != nil {
t . Fatalf ( "could not run script %v: %v (output: %q)" , args , err , string ( out ) )
}
return out
}
2020-03-28 18:18:55 +00:00
checkAutogenDoc ( t , "pkg/terminal/starbind/starlark_mapping.go" , "'go generate' inside pkg/terminal/starbind" , runScript ( "_scripts/gen-starlark-bindings.go" , "go" , "-" ) )
checkAutogenDoc ( t , "Documentation/cli/starlark.md" , "'go generate' inside pkg/terminal/starbind" , runScript ( "_scripts/gen-starlark-bindings.go" , "doc/dummy" , "Documentation/cli/starlark.md" ) )
2020-09-24 15:10:20 +00:00
checkAutogenDoc ( t , "Documentation/backend_test_health.md" , "go run _scripts/gen-backend_test_health.go" , runScript ( "_scripts/gen-backend_test_health.go" , "-" ) )
2021-08-23 18:32:02 +00:00
checkAutogenDoc ( t , "_scripts/rtype-out.txt" , "go run _scripts/rtype.go report _scripts/rtype-out.txt" , runScript ( "_scripts/rtype.go" , "report" ) )
runScript ( "_scripts/rtype.go" , "check" )
2018-04-18 07:36:40 +00:00
}
2018-11-30 08:53:29 +00:00
func TestExitInInit ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
buildtestdir := filepath . Join ( protest . FindFixturesDir ( ) , "buildtest" )
exitInit := filepath . Join ( protest . FindFixturesDir ( ) , "exit.init" )
cmd := exec . Command ( dlvbin , "--init" , exitInit , "debug" )
cmd . Dir = buildtestdir
out , err := cmd . CombinedOutput ( )
t . Logf ( "%q %v\n" , string ( out ) , err )
// dlv will exit anyway because stdin is not a tty but it will print the
// prompt once if the init file didn't call exit successfully.
if strings . Contains ( string ( out ) , "(dlv)" ) {
t . Fatal ( "init did not cause dlv to exit" )
}
}
2018-11-20 15:13:09 +00:00
func getMethods ( pkg * types . Package , typename string ) map [ string ] * types . Func {
r := make ( map [ string ] * types . Func )
mset := types . NewMethodSet ( types . NewPointer ( pkg . Scope ( ) . Lookup ( typename ) . Type ( ) ) )
for i := 0 ; i < mset . Len ( ) ; i ++ {
fn := mset . At ( i ) . Obj ( ) . ( * types . Func )
r [ fn . Name ( ) ] = fn
}
return r
}
func publicMethodOf ( decl ast . Decl , receiver string ) * ast . FuncDecl {
fndecl , isfunc := decl . ( * ast . FuncDecl )
if ! isfunc {
return nil
}
if fndecl . Name . Name [ 0 ] >= 'a' && fndecl . Name . Name [ 0 ] <= 'z' {
return nil
}
if fndecl . Recv == nil || len ( fndecl . Recv . List ) != 1 {
return nil
}
starexpr , isstar := fndecl . Recv . List [ 0 ] . Type . ( * ast . StarExpr )
if ! isstar {
return nil
}
identexpr , isident := starexpr . X . ( * ast . Ident )
if ! isident || identexpr . Name != receiver {
return nil
}
if fndecl . Body == nil {
return nil
}
return fndecl
}
func findCallCall ( fndecl * ast . FuncDecl ) * ast . CallExpr {
for _ , stmt := range fndecl . Body . List {
var x ast . Expr = nil
switch s := stmt . ( type ) {
case * ast . AssignStmt :
if len ( s . Rhs ) == 1 {
x = s . Rhs [ 0 ]
}
case * ast . ReturnStmt :
if len ( s . Results ) == 1 {
x = s . Results [ 0 ]
}
case * ast . ExprStmt :
x = s . X
}
callx , iscall := x . ( * ast . CallExpr )
if ! iscall {
continue
}
fun , issel := callx . Fun . ( * ast . SelectorExpr )
if ! issel || fun . Sel . Name != "call" {
continue
}
return callx
}
return nil
}
func qf ( * types . Package ) string {
return ""
}
func TestTypecheckRPC ( t * testing . T ) {
fset := & token . FileSet { }
cfg := & packages . Config {
2020-03-19 17:10:08 +00:00
Mode : packages . NeedSyntax | packages . NeedTypesInfo | packages . NeedName | packages . NeedCompiledGoFiles | packages . NeedTypes ,
2018-11-20 15:13:09 +00:00
Fset : fset ,
}
pkgs , err := packages . Load ( cfg , "github.com/go-delve/delve/service/rpc2" )
if err != nil {
t . Fatal ( err )
}
var clientAst * ast . File
var serverMethods map [ string ] * types . Func
var info * types . Info
packages . Visit ( pkgs , func ( pkg * packages . Package ) bool {
if pkg . PkgPath != "github.com/go-delve/delve/service/rpc2" {
return true
}
t . Logf ( "package found: %v" , pkg . PkgPath )
serverMethods = getMethods ( pkg . Types , "RPCServer" )
info = pkg . TypesInfo
for i := range pkg . Syntax {
t . Logf ( "file %q" , pkg . CompiledGoFiles [ i ] )
if strings . HasSuffix ( pkg . CompiledGoFiles [ i ] , string ( os . PathSeparator ) + "client.go" ) {
clientAst = pkg . Syntax [ i ]
break
}
}
return true
} , nil )
errcount := 0
for _ , decl := range clientAst . Decls {
fndecl := publicMethodOf ( decl , "RPCClient" )
if fndecl == nil {
continue
}
switch fndecl . Name . Name {
case "Continue" , "Rewind" :
// wrappers over continueDir
continue
case "SetReturnValuesLoadConfig" , "Disconnect" :
// support functions
continue
}
proc,terminal: Implement reverse step, next and stepout (#1785)
* proc: move defer breakpoint code into a function
Moves the code that sets a breakpoint on the first deferred function,
used by both next and StepOut, to its function.
* proc: implement reverse step/next/stepout
When the direction of execution is reversed (on a recording) Step, Next and
StepOut will behave similarly to their forward version. However there are
some subtle interactions between their behavior, prologue skipping, deferred
calls and normal calls. Specifically:
- when stepping backwards we need to set a breakpoint on the first
instruction after each CALL instruction, once this breakpoint is reached we
need to execute a single StepInstruction operation to reverse step into the
CALL.
- to insure that the prologue is skipped reverse next needs to check if it
is on the first instruction after the prologue, and if it is behave like
reverse stepout.
- there is no reason to set breakpoints on deferred calls when reverse
nexting or reverse stepping out, they will never be hit.
- reverse step out should generally place its breakpoint on the CALL
instruction that created the current stack frame (which will be the CALL
instruction immediately preceding the instruction at the return address).
- reverse step out needs to treat panic calls and deferreturn calls
specially.
* service,terminal: implement reverse step, next, stepout
2020-03-11 22:40:41 +00:00
if fndecl . Name . Name == "Continue" || fndecl . Name . Name == "Rewind" || fndecl . Name . Name == "DirectionCongruentContinue" {
2018-11-20 15:13:09 +00:00
// using continueDir
continue
}
callx := findCallCall ( fndecl )
if callx == nil {
t . Errorf ( "%s: could not find RPC call" , fset . Position ( fndecl . Pos ( ) ) )
errcount ++
continue
}
if len ( callx . Args ) != 3 {
t . Errorf ( "%s: wrong number of arguments for RPC call" , fset . Position ( callx . Pos ( ) ) )
errcount ++
continue
}
arg0 , arg0islit := callx . Args [ 0 ] . ( * ast . BasicLit )
arg1 := callx . Args [ 1 ]
arg2 := callx . Args [ 2 ]
if ! arg0islit || arg0 . Kind != token . STRING {
continue
}
name , _ := strconv . Unquote ( arg0 . Value )
serverMethod := serverMethods [ name ]
if serverMethod == nil {
t . Errorf ( "%s: could not find RPC method %q" , fset . Position ( callx . Pos ( ) ) , name )
errcount ++
continue
}
params := serverMethod . Type ( ) . ( * types . Signature ) . Params ( )
if a , e := info . TypeOf ( arg1 ) , params . At ( 0 ) . Type ( ) ; ! types . AssignableTo ( a , e ) {
t . Errorf ( "%s: wrong type of first argument %s, expected %s" , fset . Position ( callx . Pos ( ) ) , types . TypeString ( a , qf ) , types . TypeString ( e , qf ) )
errcount ++
continue
}
if ! strings . HasSuffix ( params . At ( 1 ) . Type ( ) . String ( ) , "/service.RPCCallback" ) {
if a , e := info . TypeOf ( arg2 ) , params . At ( 1 ) . Type ( ) ; ! types . AssignableTo ( a , e ) {
t . Errorf ( "%s: wrong type of second argument %s, expected %s" , fset . Position ( callx . Pos ( ) ) , types . TypeString ( a , qf ) , types . TypeString ( e , qf ) )
errcount ++
continue
}
}
if clit , ok := arg1 . ( * ast . CompositeLit ) ; ok {
typ := params . At ( 0 ) . Type ( )
st := typ . Underlying ( ) . ( * types . Struct )
if len ( clit . Elts ) != st . NumFields ( ) && types . TypeString ( typ , qf ) != "DebuggerCommand" {
t . Errorf ( "%s: wrong number of fields in first argument's literal %d, expected %d" , fset . Position ( callx . Pos ( ) ) , len ( clit . Elts ) , st . NumFields ( ) )
errcount ++
continue
}
}
}
if errcount > 0 {
t . Errorf ( "%d errors" , errcount )
}
}
2020-02-28 17:48:59 +00:00
2021-10-25 19:39:28 +00:00
// TestDAPCmd verifies that a dap server can be started and shut down.
func TestDAPCmd ( t * testing . T ) {
2020-02-28 17:48:59 +00:00
const listenAddr = "127.0.0.1:40575"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
cmd := exec . Command ( dlvbin , "dap" , "--log-output=dap" , "--log" , "--listen" , listenAddr )
stdout , err := cmd . StdoutPipe ( )
assertNoError ( err , t , "stdout pipe" )
2020-10-19 21:44:04 +00:00
defer stdout . Close ( )
2020-02-28 17:48:59 +00:00
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
2020-10-19 21:44:04 +00:00
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "start dap instance" )
2020-02-28 17:48:59 +00:00
scanOut := bufio . NewScanner ( stdout )
scanErr := bufio . NewScanner ( stderr )
// Wait for the debug server to start
scanOut . Scan ( )
listening := "DAP server listening at: " + listenAddr
if scanOut . Text ( ) != listening {
cmd . Process . Kill ( ) // release the port
t . Fatalf ( "Unexpected stdout:\ngot %q\nwant %q" , scanOut . Text ( ) , listening )
}
go func ( ) {
for scanErr . Scan ( ) {
t . Log ( scanErr . Text ( ) )
}
} ( )
// Connect a client and request shutdown.
client := daptest . NewClient ( listenAddr )
client . DisconnectRequest ( )
client . ExpectDisconnectResponse ( t )
2021-07-14 21:32:46 +00:00
client . ExpectTerminatedEvent ( t )
2020-02-28 17:48:59 +00:00
if _ , err := client . ReadMessage ( ) ; err != io . EOF {
t . Errorf ( "got %q, want \"EOF\"\n" , err )
}
client . Close ( )
cmd . Wait ( )
}
2020-05-13 06:38:10 +00:00
2022-04-01 17:31:23 +00:00
func TestDAPCmdWithNoDebugBinary ( t * testing . T ) {
const listenAddr = "127.0.0.1:40579"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
cmd := exec . Command ( dlvbin , "dap" , "--log" , "--listen" , listenAddr )
stdout , err := cmd . StdoutPipe ( )
assertNoError ( err , t , "stdout pipe" )
defer stdout . Close ( )
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "start dap instance" )
scanOut := bufio . NewScanner ( stdout )
scanErr := bufio . NewScanner ( stderr )
// Wait for the debug server to start
scanOut . Scan ( )
listening := "DAP server listening at: " + listenAddr
if scanOut . Text ( ) != listening {
cmd . Process . Kill ( ) // release the port
t . Fatalf ( "Unexpected stdout:\ngot %q\nwant %q" , scanOut . Text ( ) , listening )
}
go func ( ) { // Capture logging
for scanErr . Scan ( ) {
t . Log ( scanErr . Text ( ) )
}
} ( )
// Exec the stripped debuggee and expect things to fail
noDebugFlags := protest . LinkStrip
// -s doesn't strip symbols on Mac, use -w instead
if runtime . GOOS == "darwin" {
noDebugFlags = protest . LinkDisableDWARF
}
fixture := protest . BuildFixture ( "increment" , noDebugFlags )
go func ( ) {
for scanOut . Scan ( ) {
t . Errorf ( "Unexpected stdout: %s" , scanOut . Text ( ) )
}
} ( )
client := daptest . NewClient ( listenAddr )
client . LaunchRequest ( "exec" , fixture . Path , false )
client . ExpectErrorResponse ( t )
client . DisconnectRequest ( )
client . ExpectDisconnectResponse ( t )
client . ExpectTerminatedEvent ( t )
client . Close ( )
cmd . Wait ( )
}
2021-10-25 19:39:28 +00:00
func newDAPRemoteClient ( t * testing . T , addr string ) * daptest . Client {
c := daptest . NewClient ( addr )
c . AttachRequest ( map [ string ] interface { } { "mode" : "remote" , "stopOnEntry" : true } )
2022-03-22 14:19:56 +00:00
c . ExpectCapabilitiesEventSupportTerminateDebuggee ( t )
2021-10-25 19:39:28 +00:00
c . ExpectInitializedEvent ( t )
c . ExpectAttachResponse ( t )
c . ConfigurationDoneRequest ( )
c . ExpectStoppedEvent ( t )
c . ExpectConfigurationDoneResponse ( t )
return c
}
func TestRemoteDAPClient ( t * testing . T ) {
const listenAddr = "127.0.0.1:40576"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
buildtestdir := filepath . Join ( protest . FindFixturesDir ( ) , "buildtest" )
cmd := exec . Command ( dlvbin , "debug" , "--headless" , "--log-output=dap" , "--log" , "--listen" , listenAddr )
cmd . Dir = buildtestdir
stdout , err := cmd . StdoutPipe ( )
assertNoError ( err , t , "stdout pipe" )
defer stdout . Close ( )
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "start headless instance" )
scanOut := bufio . NewScanner ( stdout )
scanErr := bufio . NewScanner ( stderr )
// Wait for the debug server to start
scanOut . Scan ( )
t . Log ( scanOut . Text ( ) )
go func ( ) { // Capture logging
for scanErr . Scan ( ) {
t . Log ( scanErr . Text ( ) )
}
} ( )
client := newDAPRemoteClient ( t , listenAddr )
client . ContinueRequest ( 1 )
client . ExpectContinueResponse ( t )
client . ExpectTerminatedEvent ( t )
client . DisconnectRequest ( )
client . ExpectOutputEventProcessExited ( t , 0 )
client . ExpectOutputEventDetaching ( t )
client . ExpectDisconnectResponse ( t )
client . ExpectTerminatedEvent ( t )
if _ , err := client . ReadMessage ( ) ; err == nil {
t . Error ( "expected read error upon shutdown" )
}
client . Close ( )
cmd . Wait ( )
}
2021-12-07 17:23:26 +00:00
func closeDAPRemoteMultiClient ( t * testing . T , c * daptest . Client , expectStatus string ) {
2021-10-25 19:39:28 +00:00
c . DisconnectRequest ( )
2021-12-07 17:23:26 +00:00
c . ExpectOutputEventClosingClient ( t , expectStatus )
2021-10-25 19:39:28 +00:00
c . ExpectDisconnectResponse ( t )
c . ExpectTerminatedEvent ( t )
c . Close ( )
time . Sleep ( 10 * time . Millisecond )
}
func TestRemoteDAPClientMulti ( t * testing . T ) {
const listenAddr = "127.0.0.1:40577"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
buildtestdir := filepath . Join ( protest . FindFixturesDir ( ) , "buildtest" )
cmd := exec . Command ( dlvbin , "debug" , "--headless" , "--accept-multiclient" , "--log-output=debugger" , "--log" , "--listen" , listenAddr )
cmd . Dir = buildtestdir
stdout , err := cmd . StdoutPipe ( )
assertNoError ( err , t , "stdout pipe" )
defer stdout . Close ( )
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "start headless instance" )
scanOut := bufio . NewScanner ( stdout )
scanErr := bufio . NewScanner ( stderr )
// Wait for the debug server to start
scanOut . Scan ( )
t . Log ( scanOut . Text ( ) )
go func ( ) { // Capture logging
for scanErr . Scan ( ) {
t . Log ( scanErr . Text ( ) )
}
} ( )
2021-12-07 17:23:26 +00:00
// Client 0 connects but with the wrong attach request
dapclient0 := daptest . NewClient ( listenAddr )
dapclient0 . AttachRequest ( map [ string ] interface { } { "mode" : "local" } )
dapclient0 . ExpectErrorResponse ( t )
2021-10-25 19:39:28 +00:00
// Client 1 connects and continues to main.main
dapclient := newDAPRemoteClient ( t , listenAddr )
dapclient . SetFunctionBreakpointsRequest ( [ ] godap . FunctionBreakpoint { { Name : "main.main" } } )
dapclient . ExpectSetFunctionBreakpointsResponse ( t )
dapclient . ContinueRequest ( 1 )
dapclient . ExpectContinueResponse ( t )
dapclient . ExpectStoppedEvent ( t )
dapclient . CheckStopLocation ( t , 1 , "main.main" , 5 )
2021-12-07 17:23:26 +00:00
closeDAPRemoteMultiClient ( t , dapclient , "halted" )
2021-10-25 19:39:28 +00:00
// Client 2 reconnects at main.main and continues to process exit
dapclient2 := newDAPRemoteClient ( t , listenAddr )
dapclient2 . CheckStopLocation ( t , 1 , "main.main" , 5 )
dapclient2 . ContinueRequest ( 1 )
dapclient2 . ExpectContinueResponse ( t )
dapclient2 . ExpectTerminatedEvent ( t )
2021-12-07 17:23:26 +00:00
closeDAPRemoteMultiClient ( t , dapclient2 , "exited" )
2021-10-25 19:39:28 +00:00
2022-03-23 15:10:00 +00:00
// Attach to exited processes is an error
2021-10-25 19:39:28 +00:00
dapclient3 := daptest . NewClient ( listenAddr )
dapclient3 . AttachRequest ( map [ string ] interface { } { "mode" : "remote" , "stopOnEntry" : true } )
dapclient3 . ExpectErrorResponseWith ( t , dap . FailedToAttach , ` Process \d+ has exited with status 0 ` , true )
2021-12-07 17:23:26 +00:00
closeDAPRemoteMultiClient ( t , dapclient3 , "exited" )
2021-10-25 19:39:28 +00:00
// But rpc clients can still connect and restart
rpcclient := rpc2 . NewClient ( listenAddr )
if _ , err := rpcclient . Restart ( false ) ; err != nil {
t . Errorf ( "error restarting with rpc client: %v" , err )
}
if err := rpcclient . Detach ( true ) ; err != nil {
t . Fatalf ( "error detaching from headless instance: %v" , err )
}
cmd . Wait ( )
}
func TestRemoteDAPClientAfterContinue ( t * testing . T ) {
const listenAddr = "127.0.0.1:40578"
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
fixture := protest . BuildFixture ( "loopprog" , 0 )
cmd := exec . Command ( dlvbin , "exec" , fixture . Path , "--headless" , "--continue" , "--accept-multiclient" , "--log-output=debugger,dap" , "--log" , "--listen" , listenAddr )
stdout , err := cmd . StdoutPipe ( )
assertNoError ( err , t , "stdout pipe" )
defer stdout . Close ( )
stderr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
defer stderr . Close ( )
assertNoError ( cmd . Start ( ) , t , "start headless instance" )
scanOut := bufio . NewScanner ( stdout )
scanErr := bufio . NewScanner ( stderr )
// Wait for the debug server to start
scanOut . Scan ( ) // "API server listening...""
t . Log ( scanOut . Text ( ) )
// Wait for the program to start
scanOut . Scan ( ) // "past main"
t . Log ( scanOut . Text ( ) )
go func ( ) { // Capture logging
for scanErr . Scan ( ) {
2021-11-09 08:24:26 +00:00
text := scanErr . Text ( )
if strings . Contains ( text , "Internal Error" ) {
t . Error ( "ERROR" , text )
} else {
t . Log ( text )
}
2021-10-25 19:39:28 +00:00
}
} ( )
c := newDAPRemoteClient ( t , listenAddr )
2021-11-09 08:24:26 +00:00
c . ContinueRequest ( 1 )
c . ExpectContinueResponse ( t )
c . DisconnectRequest ( )
2021-12-08 10:37:35 +00:00
c . ExpectOutputEventClosingClient ( t , "running" )
2021-11-09 08:24:26 +00:00
c . ExpectDisconnectResponse ( t )
c . ExpectTerminatedEvent ( t )
c . Close ( )
c = newDAPRemoteClient ( t , listenAddr )
2021-10-25 19:39:28 +00:00
c . DisconnectRequestWithKillOption ( true )
c . ExpectOutputEventDetachingKill ( t )
c . ExpectDisconnectResponse ( t )
c . ExpectTerminatedEvent ( t )
if _ , err := c . ReadMessage ( ) ; err == nil {
t . Error ( "expected read error upon shutdown" )
}
c . Close ( )
cmd . Wait ( )
}
// TestDAPCmdWithClient tests dlv dap --client-addr can be started and shut down.
func TestDAPCmdWithClient ( t * testing . T ) {
2021-10-13 18:43:47 +00:00
listener , err := net . Listen ( "tcp" , ":0" )
if err != nil {
t . Fatalf ( "cannot setup listener required for testing: %v" , err )
}
defer listener . Close ( )
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
cmd := exec . Command ( dlvbin , "dap" , "--log-output=dap" , "--log" , "--client-addr" , listener . Addr ( ) . String ( ) )
buf := & bytes . Buffer { }
cmd . Stdin = buf
cmd . Stdout = buf
assertNoError ( cmd . Start ( ) , t , "start dlv dap process with --client-addr flag" )
// Wait for the connection.
conn , err := listener . Accept ( )
if err != nil {
cmd . Process . Kill ( ) // release the port
t . Fatalf ( "Failed to get connection: %v" , err )
}
t . Log ( "dlv dap process dialed in successfully" )
client := daptest . NewClientFromConn ( conn )
client . InitializeRequest ( )
client . ExpectInitializeResponse ( t )
// Close the connection.
if err := conn . Close ( ) ; err != nil {
cmd . Process . Kill ( )
t . Fatalf ( "Failed to get connection: %v" , err )
}
// Connection close should trigger dlv-reverse command's normal exit.
if err := cmd . Wait ( ) ; err != nil {
cmd . Process . Kill ( )
t . Fatalf ( "command failed: %v\n%s\n%v" , err , buf . Bytes ( ) , cmd . Process . Pid )
}
}
2020-05-13 06:38:10 +00:00
func TestTrace ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
expected := [ ] byte ( "> goroutine(1): main.foo(99, 9801) => (9900)\n" )
fixtures := protest . FindFixturesDir ( )
cmd := exec . Command ( dlvbin , "trace" , "--output" , filepath . Join ( tmpdir , "__debug" ) , filepath . Join ( fixtures , "issue573.go" ) , "foo" )
rdr , err := cmd . StderrPipe ( )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "stderr pipe" )
defer rdr . Close ( )
2020-05-13 06:38:10 +00:00
cmd . Dir = filepath . Join ( fixtures , "buildtest" )
2020-10-19 21:44:04 +00:00
assertNoError ( cmd . Start ( ) , t , "running trace" )
2020-05-13 06:38:10 +00:00
output , err := ioutil . ReadAll ( rdr )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "ReadAll" )
2020-05-13 06:38:10 +00:00
if ! bytes . Contains ( output , expected ) {
t . Fatalf ( "expected:\n%s\ngot:\n%s" , string ( expected ) , string ( output ) )
}
cmd . Wait ( )
}
2020-06-02 19:07:03 +00:00
func TestTracePid ( t * testing . T ) {
if runtime . GOOS == "linux" {
bs , _ := ioutil . ReadFile ( "/proc/sys/kernel/yama/ptrace_scope" )
if bs == nil || strings . TrimSpace ( string ( bs ) ) != "0" {
t . Logf ( "can not run TestAttachDetach: %v\n" , bs )
return
}
}
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
2022-01-27 21:18:25 +00:00
expected := [ ] byte ( "goroutine(1): main.A()\n => ()\n" )
2020-06-02 19:07:03 +00:00
// make process run
fix := protest . BuildFixture ( "issue2023" , 0 )
targetCmd := exec . Command ( fix . Path )
2020-10-19 21:44:04 +00:00
assertNoError ( targetCmd . Start ( ) , t , "execute issue2023" )
2020-06-02 19:07:03 +00:00
if targetCmd . Process == nil || targetCmd . Process . Pid == 0 {
t . Fatal ( "expected target process runninng" )
}
defer targetCmd . Process . Kill ( )
// dlv attach the process by pid
cmd := exec . Command ( dlvbin , "trace" , "-p" , strconv . Itoa ( targetCmd . Process . Pid ) , "main.A" )
rdr , err := cmd . StderrPipe ( )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "stderr pipe" )
defer rdr . Close ( )
assertNoError ( cmd . Start ( ) , t , "running trace" )
2020-06-02 19:07:03 +00:00
output , err := ioutil . ReadAll ( rdr )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "ReadAll" )
2020-06-02 19:07:03 +00:00
if ! bytes . Contains ( output , expected ) {
t . Fatalf ( "expected:\n%s\ngot:\n%s" , string ( expected ) , string ( output ) )
}
cmd . Wait ( )
}
2020-05-13 06:38:10 +00:00
func TestTraceBreakpointExists ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
fixtures := protest . FindFixturesDir ( )
// We always set breakpoints on some runtime functions at startup, so this would return with
// a breakpoints exists error.
// TODO: Perhaps we shouldn't be setting these default breakpoints in trace mode, however.
cmd := exec . Command ( dlvbin , "trace" , "--output" , filepath . Join ( tmpdir , "__debug" ) , filepath . Join ( fixtures , "issue573.go" ) , "runtime.*" )
rdr , err := cmd . StderrPipe ( )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "stderr pipe" )
defer rdr . Close ( )
2020-05-13 06:38:10 +00:00
cmd . Dir = filepath . Join ( fixtures , "buildtest" )
2020-10-19 21:44:04 +00:00
assertNoError ( cmd . Start ( ) , t , "running trace" )
2020-05-13 06:38:10 +00:00
defer cmd . Wait ( )
output , err := ioutil . ReadAll ( rdr )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "ReadAll" )
2020-05-13 06:38:10 +00:00
if bytes . Contains ( output , [ ] byte ( "Breakpoint exists" ) ) {
t . Fatal ( "Breakpoint exists errors should be ignored" )
}
}
func TestTracePrintStack ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
fixtures := protest . FindFixturesDir ( )
cmd := exec . Command ( dlvbin , "trace" , "--output" , filepath . Join ( tmpdir , "__debug" ) , "--stack" , "2" , filepath . Join ( fixtures , "issue573.go" ) , "foo" )
rdr , err := cmd . StderrPipe ( )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "stderr pipe" )
defer rdr . Close ( )
2020-05-13 06:38:10 +00:00
cmd . Dir = filepath . Join ( fixtures , "buildtest" )
2020-10-19 21:44:04 +00:00
assertNoError ( cmd . Start ( ) , t , "running trace" )
2020-05-13 06:38:10 +00:00
defer cmd . Wait ( )
output , err := ioutil . ReadAll ( rdr )
2020-10-19 21:44:04 +00:00
assertNoError ( err , t , "ReadAll" )
2020-05-13 06:38:10 +00:00
if ! bytes . Contains ( output , [ ] byte ( "Stack:" ) ) && ! bytes . Contains ( output , [ ] byte ( "main.main" ) ) {
t . Fatal ( "stacktrace not printed" )
}
}
2020-08-31 17:51:10 +00:00
2021-08-24 12:53:27 +00:00
func TestTraceEBPF ( t * testing . T ) {
if os . Getenv ( "CI" ) == "true" {
t . Skip ( "cannot run test in CI, requires kernel compiled with btf support" )
}
if runtime . GOOS != "linux" || runtime . GOARCH != "amd64" {
t . Skip ( "not implemented on non linux/amd64 systems" )
}
if ! goversion . VersionAfterOrEqual ( runtime . Version ( ) , 1 , 16 ) {
t . Skip ( "requires at least Go 1.16 to run test" )
}
usr , err := user . Current ( )
if err != nil {
t . Fatal ( err )
}
if usr . Uid != "0" {
t . Skip ( "test must be run as root" )
}
dlvbin , tmpdir := getDlvBinEBPF ( t )
defer os . RemoveAll ( tmpdir )
2021-10-25 19:37:36 +00:00
expected := [ ] byte ( "> (1) main.foo(99, 9801)\n=> \"9900\"" )
2021-08-24 12:53:27 +00:00
fixtures := protest . FindFixturesDir ( )
cmd := exec . Command ( dlvbin , "trace" , "--ebpf" , "--output" , filepath . Join ( tmpdir , "__debug" ) , filepath . Join ( fixtures , "issue573.go" ) , "foo" )
rdr , err := cmd . StderrPipe ( )
assertNoError ( err , t , "stderr pipe" )
defer rdr . Close ( )
assertNoError ( cmd . Start ( ) , t , "running trace" )
output , err := ioutil . ReadAll ( rdr )
assertNoError ( err , t , "ReadAll" )
if ! bytes . Contains ( output , expected ) {
t . Fatalf ( "expected:\n%s\ngot:\n%s" , string ( expected ) , string ( output ) )
}
cmd . Wait ( )
}
2020-08-31 17:51:10 +00:00
func TestDlvTestChdir ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
fixtures := protest . FindFixturesDir ( )
2020-08-21 14:14:02 +00:00
cmd := exec . Command ( dlvbin , "--allow-non-terminal-interactive=true" , "test" , filepath . Join ( fixtures , "buildtest" ) , "--" , "-test.v" )
2020-08-31 17:51:10 +00:00
cmd . Stdin = strings . NewReader ( "continue\nexit\n" )
out , err := cmd . CombinedOutput ( )
if err != nil {
t . Fatalf ( "error executing Delve: %v" , err )
}
t . Logf ( "output: %q" , out )
p , _ := filepath . Abs ( filepath . Join ( fixtures , "buildtest" ) )
tgt := "current directory: " + p
if ! strings . Contains ( string ( out ) , tgt ) {
t . Errorf ( "output did not contain expected string %q" , tgt )
}
}
2021-07-27 16:38:48 +00:00
func TestVersion ( t * testing . T ) {
dlvbin , tmpdir := getDlvBin ( t )
defer os . RemoveAll ( tmpdir )
got , err := exec . Command ( dlvbin , "version" , "-v" ) . CombinedOutput ( )
if err != nil {
t . Fatalf ( "error executing `dlv version`: %v\n%s\n" , err , got )
}
want1 := [ ] byte ( "mod\tgithub.com/go-delve/delve" )
want2 := [ ] byte ( "dep\tgithub.com/google/go-dap" )
if ! bytes . Contains ( got , want1 ) || ! bytes . Contains ( got , want2 ) {
t . Errorf ( "got %s\nwant %v and %v in the output" , got , want1 , want2 )
}
}
2021-09-24 22:31:54 +00:00
func TestStaticcheck ( t * testing . T ) {
2021-10-30 18:52:26 +00:00
if goversion . VersionAfterOrEqual ( runtime . Version ( ) , 1 , 18 ) {
//TODO(aarzilli): remove this before version 1.8.0 is released
t . Skip ( "staticcheck does not currently support Go 1.18" )
}
2021-09-24 22:31:54 +00:00
_ , err := exec . LookPath ( "staticcheck" )
if err != nil {
t . Skip ( "staticcheck not installed" )
}
// default checks minus SA1019 which complains about deprecated identifiers, which change between versions of Go.
2021-09-28 19:07:42 +00:00
args := [ ] string { "-tests=false" , "-checks=all,-SA1019,-ST1000,-ST1003,-ST1016,-S1021,-ST1023" , "github.com/go-delve/delve/..." }
// * SA1019 is disabled because new deprecations get added on every version
// of Go making the output of staticcheck inconsistent depending on the
// version of Go used to run it.
// * ST1000,ST1003,ST1016 are disabled in the default
// staticcheck configuration
// * S1021 "Merge variable declaration and assignment" is disabled because
// where we don't do this it is a deliberate style choice.
// * ST1023 "Redundant type in variable declaration" same as S1021.
2021-09-24 22:31:54 +00:00
cmd := exec . Command ( "staticcheck" , args ... )
cmd . Dir = projectRoot ( )
cmd . Env = append ( os . Environ ( ) , "GOOS=linux" , "GOARCH=amd64" )
out , _ := cmd . CombinedOutput ( )
checkAutogenDoc ( t , "_scripts/staticcheck-out.txt" , fmt . Sprintf ( "staticcheck %s > _scripts/staticcheck-out.txt" , strings . Join ( args , " " ) ) , out )
}