PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pkg/proc: Drop state from BinaryInfo

Browse Source 
Remove `initialized` member in favor of just deriving the information it
represented.
This commit is contained in:
Derek Parker 2019-08-08 12:39:52 -07:00 committed by Alessandro Arzilli
parent b87813e177
commit 094915e4aa
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/proc/bininfo.go
View File

@ -80,8 +80,6 @@ type BinaryInfo struct {
// consts[off] lists all the constants with the type defined at offset off. // consts[off] lists all the constants with the type defined at offset off.
consts constantsMap consts constantsMap
initialized bool
} }
// ErrUnsupportedLinuxArch is returned when attempting to debug a binary compiled for an unsupported architecture. // ErrUnsupportedLinuxArch is returned when attempting to debug a binary compiled for an unsupported architecture.
@ -1236,11 +1234,14 @@ func (bi *BinaryInfo) loadDebugInfoMaps(image *Image, debugLineBytes []byte, wg
defer wg.Done() defer wg.Done()
} }
if !bi.initialized { if bi.types == nil {
bi.types = make(map[string]dwarfRef) bi.types = make(map[string]dwarfRef)
}
if bi.consts == nil {
bi.consts = make(map[dwarfRef]*constantType) bi.consts = make(map[dwarfRef]*constantType)
}
if bi.packageMap == nil {
bi.packageMap = make(map[string]string) bi.packageMap = make(map[string]string)
bi.initialized = true
} }
image.runtimeTypeToDIE = make(map[uint64]runtimeTypeDIE) image.runtimeTypeToDIE = make(map[uint64]runtimeTypeDIE)