pkg/logflags: Display warning when unknown component for --log-output (#1897)

This commit is contained in:
chainhelen 2020-02-28 11:50:22 -06:00 committed by GitHub
parent 0f9b05b9f5
commit 0a650a0e0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -160,6 +160,8 @@ func Setup(logFlag bool, logstr string, logDest string) error {
} }
v := strings.Split(logstr, ",") v := strings.Split(logstr, ",")
for _, logcmd := range v { for _, logcmd := range v {
// If adding another value, do make sure to
// update "Help about logging flags" in commands.go.
switch logcmd { switch logcmd {
case "debugger": case "debugger":
debugger = true debugger = true
@ -177,8 +179,8 @@ func Setup(logFlag bool, logstr string, logDest string) error {
fnCall = true fnCall = true
case "minidump": case "minidump":
minidump = true minidump = true
// If adding another value, do make sure to default:
// update "Help about logging flags" in commands.go. fmt.Fprintf(os.Stderr, "Warning: unknown log output value %q, run 'dlv help log' for usage.\n", logcmd)
} }
} }
return nil return nil