PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

service/api: do not try to convert unreadable goroutines (#2070)

Browse Source 
When reading truncated core files GoroutinesInfo will sometimes produce
some proc.G structs with only the Unreadable field set. These proc.G
can not be used for anything, but the service layer will still try to
convert them.
Since they are not fully initialized parts of the conversion will fail,
api.ConvertGoroutine should not try to call methods of unreadable
goroutines.

Fixes a bug reported on the mailing list.
https://groups.google.com/forum/#!msg/delve-dev/gauDqYaD81c/K5YDNBOhAAAJ
This commit is contained in:
Alessandro Arzilli 2020-06-03 20:10:14 +02:00 committed by GitHub
parent fecf14bd19
commit 2d6bc19ad7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
service/api/conversions.go
View File

@ -257,7 +257,10 @@ func ConvertGoroutine(g *proc.G) *Goroutine {
if th != nil {
tid = th.ThreadID()
}
r := &Goroutine{
if g.Unreadable != nil {
return &Goroutine{Unreadable: g.Unreadable.Error()}
}
return &Goroutine{
ID: g.ID,
CurrentLoc: ConvertLocation(g.CurrentLoc),
UserCurrentLoc: ConvertLocation(g.UserCurrent()),
@ -266,10 +269,6 @@ func ConvertGoroutine(g *proc.G) *Goroutine {
ThreadID: tid,
Labels: g.Labels(),
}
if g.Unreadable != nil {
r.Unreadable = g.Unreadable.Error()
}
return r
}
// ConvertLocation converts from proc.Location to api.Location.