PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: update a comment (#2266)

Browse Source 
The comment on the advanceRegs() method was referencing several
nonexistent fields. This patch fixes that, and improves the comment to
reference the peculiar interaction between the method and it.regs.
This commit is contained in:
Andrei Matei 2020-12-14 12:00:27 -05:00 committed by GitHub
parent fbfad81968
commit 36050b1a37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/proc/stack.go
View File

@ -407,9 +407,15 @@ func (it *stackIterator) appendInlineCalls(frames []Stackframe, frame Stackframe
return append(frames, frame) return append(frames, frame)
} }
// advanceRegs calculates it.callFrameRegs using it.regs and the frame // advanceRegs calculates the DwarfRegisters for a next stack frame
// descriptor entry for the current stack frame. // (corresponding to it.pc).
// it.regs.CallFrameCFA is updated. //
// The computation uses the registers for the current stack frame (it.regs) and
// the corresponding Frame Descriptor Entry (FDE) retrieved from the DWARF info.
//
// The new set of registers is returned. it.regs is not updated, except for
// it.regs.CFA; the caller has to eventually switch it.regs when the iterator
// advances to the next frame.
func (it *stackIterator) advanceRegs() (callFrameRegs op.DwarfRegisters, ret uint64, retaddr uint64) { func (it *stackIterator) advanceRegs() (callFrameRegs op.DwarfRegisters, ret uint64, retaddr uint64) {
fde, err := it.bi.frameEntries.FDEForPC(it.pc) fde, err := it.bi.frameEntries.FDEForPC(it.pc)
var framectx *frame.FrameContext var framectx *frame.FrameContext