PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: Find executable should follow symbol links.

Browse Source 
On linux platform, we simply treated `/proc/$pid/exe` as the
executable of targeting process when doing `dlv attach`. The
`/proc/$pid/exe` is a symbol link of the real executable file.
Delve couldn't find the corrsponding external debug file based on the
symbol link:

```
could not attach to pid $pid: could not open debug info
```

The fix is to evaluate the symbol links to the actual executable path.
This commit is contained in:
Min Zhou 2020-04-23 14:37:54 -07:00 committed by Derek Parker
parent 37bee98a88
commit 3e04ad0fad
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/proc/native/proc_linux.go
View File

@ -119,7 +119,12 @@ func Attach(pid int, debugInfoDirs []string) (*proc.Target, error) {
return nil, err
}
tgt, err := dbp.initialize(findExecutable("", dbp.pid), debugInfoDirs)
execPath, err := findExecutable(pid)
if err != nil {
return nil, err
}
tgt, err := dbp.initialize(execPath, debugInfoDirs)
if err != nil {
dbp.Detach(false)
return nil, err
@ -249,11 +254,9 @@ func (dbp *nativeProcess) updateThreadList() error {
return linutil.ElfUpdateSharedObjects(dbp)
}
func findExecutable(path string, pid int) string {
if path == "" {
path = fmt.Sprintf("/proc/%d/exe", pid)
}
return path
func findExecutable(pid int) (string, error) {
path := fmt.Sprintf("/proc/%d/exe", pid)
return filepath.EvalSymlinks(path)
}
func (dbp *nativeProcess) trapWait(pid int) (*nativeThread, error) {