PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TeamCity: reupgrade linux/386 builder to Go 1.21 (#3560)

Browse Source 
The bug that prevented updating to linux/386 has been fixed upstream,
update linux/386 to 1.21 in the test matrix and fix some broken bugs.
This commit is contained in:
Alessandro Arzilli 2023-11-10 00:38:37 +01:00 committed by GitHub
parent aec354cd0b
commit 438d036fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.teamcity/settings.kts vendored
View File

@ -40,7 +40,7 @@ val targets = arrayOf(
"linux/amd64/1.21", "linux/amd64/1.21",
"linux/amd64/tip", "linux/amd64/tip",
"linux/386/1.20", "linux/386/1.21",
"linux/arm64/1.21", "linux/arm64/1.21",
"linux/arm64/tip", "linux/arm64/tip",

3
Documentation/backend_test_health.md
View File

@ -1,6 +1,7 @@
Tests skipped by each supported backend: Tests skipped by each supported backend:
* 386 skipped = 6 * 386 skipped = 7
* 1 broken
* 3 broken - cgo stacktraces * 3 broken - cgo stacktraces
* 3 not implemented * 3 not implemented
* arm64 skipped = 1 * arm64 skipped = 1

2
pkg/proc/proc_test.go
View File

@ -4683,8 +4683,8 @@ func TestCgoStacktrace2(t *testing.T) {
if !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) { if !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
skipOn(t, "upstream issue", "windows") skipOn(t, "upstream issue", "windows")
skipOn(t, "broken", "arm64") skipOn(t, "broken", "arm64")
skipOn(t, "broken", "386")
} }
skipOn(t, "broken", "386")
skipOn(t, "broken - cgo stacktraces", "darwin", "arm64") skipOn(t, "broken - cgo stacktraces", "darwin", "arm64")
skipOn(t, "broken", "ppc64le") skipOn(t, "broken", "ppc64le")
protest.MustHaveCgo(t) protest.MustHaveCgo(t)

6
service/dap/server_test.go
View File

@ -1282,7 +1282,7 @@ func TestFunctionNameFormattingInStackTrace(t *testing.T) {
[]onBreakpoint{{ []onBreakpoint{{
// Stop at line 36 // Stop at line 36
execute: func() { execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) { if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1) client.StepInRequest(1)
client.ExpectStepInResponse(t) client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t) client.ExpectStoppedEvent(t)
@ -2463,7 +2463,7 @@ func TestGlobalScopeAndVariables(t *testing.T) {
[]onBreakpoint{{ []onBreakpoint{{
// Stop at line 36 // Stop at line 36
execute: func() { execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) { if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1) client.StepInRequest(1)
client.ExpectStepInResponse(t) client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t) client.ExpectStoppedEvent(t)
@ -2538,7 +2538,7 @@ func TestRegistersScopeAndVariables(t *testing.T) {
[]onBreakpoint{{ []onBreakpoint{{
// Stop at line 36 // Stop at line 36
execute: func() { execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) { if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1) client.StepInRequest(1)
client.ExpectStepInResponse(t) client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t) client.ExpectStoppedEvent(t)