PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: better handling of bad DW_TAG_inlined_subroutine without debug_line (#1722)

Browse Source 
Avoid crashing with nil pointer dereference, signal error instead.

Fixes #1720
This commit is contained in:
Alessandro Arzilli 2019-10-21 19:43:03 +02:00 committed by Derek Parker
parent 52c395eb64
commit 45fb477379
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/dwarf/line/state_machine.go
View File

@ -322,6 +322,10 @@ func (lineInfo *DebugLineInfo) LineToPC(filename string, lineno int) uint64 {
// PrologueEndPC returns the first PC address marked as prologue_end in the half open interval [start, end)
func (lineInfo *DebugLineInfo) PrologueEndPC(start, end uint64) (pc uint64, file string, line int, ok bool) {
if lineInfo == nil {
return 0, "", 0, false
}
sm := lineInfo.stateMachineForEntry(start)
for {
if sm.valid {

5
pkg/proc/bininfo.go
View File

@ -1608,6 +1608,11 @@ func (bi *BinaryInfo) loadDebugInfoMapsInlinedCalls(ctxt *loadDebugInfoMapsConte
reader.SkipChildren()
continue
}
if cu.lineInfo == nil {
bi.logger.Errorf("Error reading debug_info: inlined call on a compilation unit without debug_line section at %#x", entry.Offset)
reader.SkipChildren()
continue
}
if int(callfileidx-1) >= len(cu.lineInfo.FileNames) {
bi.logger.Errorf("Error reading debug_info: CallFile (%d) of inlined call does not exist in compile unit file table at %#x", callfileidx, entry.Offset)
reader.SkipChildren()