PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc/core: return true for calls to Recorded (#2979)

Browse Source 
The recent refactoring that introduced ContinueOnceContext broke this old behavior.

Fixes #2978
This commit is contained in:
Alessandro Arzilli 2022-05-04 19:56:41 +02:00 committed by GitHub
parent c9d800edb9
commit 55e37e2fc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/proc/core/core.go
View File

@ -248,7 +248,9 @@ func (p *process) WriteBreakpoint(*proc.Breakpoint) error {
func (p *process) Recorded() (bool, string) { return true, "" } func (p *process) Recorded() (bool, string) { return true, "" }
// Restart will only return an error for core files, as they are not executing. // Restart will only return an error for core files, as they are not executing.
func (p *process) Restart(string) (proc.Thread, error) { return nil, ErrContinueCore } func (p *process) Restart(*proc.ContinueOnceContext, string) (proc.Thread, error) {
return nil, ErrContinueCore
}
// ChangeDirection will only return an error as you cannot continue a core process. // ChangeDirection will only return an error as you cannot continue a core process.
func (p *process) ChangeDirection(proc.Direction) error { return ErrContinueCore } func (p *process) ChangeDirection(proc.Direction) error { return ErrContinueCore }

5
pkg/proc/core/core_test.go
View File

@ -257,6 +257,11 @@ func TestCore(t *testing.T) {
} }
p := withCoreFile(t, "panic", "") p := withCoreFile(t, "panic", "")
recorded, _ := p.Recorded()
if !recorded {
t.Fatalf("expecting recorded to be true")
}
gs, _, err := proc.GoroutinesInfo(p, 0, 0) gs, _, err := proc.GoroutinesInfo(p, 0, 0)
if err != nil || len(gs) == 0 { if err != nil || len(gs) == 0 {
t.Fatalf("GoroutinesInfo() = %v, %v; wanted at least one goroutine", gs, err) t.Fatalf("GoroutinesInfo() = %v, %v; wanted at least one goroutine", gs, err)