PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: when converting registers to slices set Base address (#2517)

Browse Source 
If the base address isn't set then indexing and slicing will not work.
Large floating point registers already had the base set but small
general purpose registers did not.
This commit is contained in:
Alessandro Arzilli 2021-06-02 22:46:24 +02:00 committed by GitHub
parent b2afb7cd20
commit 585c711ce5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
_fixtures/fputest/fputest_amd64.s
View File

@ -56,6 +56,8 @@ TEXT ·fputestsetup(SB),$0-50
MOVAPS X1, X9 MOVAPS X1, X9
MOVAPS X2, X10 MOVAPS X2, X10
MOVQ $42, AX
CMPB avx2+48(FP), $0x0 CMPB avx2+48(FP), $0x0
JE done JE done
//copy XMM1 to both halves of YMM11 //copy XMM1 to both halves of YMM11

1
pkg/proc/variables.go
View File

@ -2318,6 +2318,7 @@ func (v *Variable) registerVariableTypeConv(newtyp string) (*Variable, error) {
v.loaded = true v.loaded = true
v.Kind = reflect.Array v.Kind = reflect.Array
v.Len = int64(len(v.Children)) v.Len = int64(len(v.Children))
v.Base = fakeAddress
v.DwarfType = fakeArrayType(uint64(len(v.Children)), &godwarf.VoidType{CommonType: godwarf.CommonType{ByteSize: int64(n)}}) v.DwarfType = fakeArrayType(uint64(len(v.Children)), &godwarf.VoidType{CommonType: godwarf.CommonType{ByteSize: int64(n)}})
v.RealType = v.DwarfType v.RealType = v.DwarfType
return v, nil return v, nil

1
service/test/integration2_test.go
View File

@ -1598,6 +1598,7 @@ func TestClientServer_FpRegisters(t *testing.T) {
{"XMM1.uint16[0]", `52429`}, {"XMM1.uint16[0]", `52429`},
{"XMM1.float32[0]", `-107374184`}, {"XMM1.float32[0]", `-107374184`},
{"XMM1.float64[0]", `1.3`}, {"XMM1.float64[0]", `1.3`},
{"RAX.uint8[0]", "42"},
} { } {
v, err := c.EvalVariable(scope, tc.expr, normalLoadConfig) v, err := c.EvalVariable(scope, tc.expr, normalLoadConfig)
if err != nil { if err != nil {