PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: bugfix: unsigned integer overflow in proc.(*memCache).contains (#555)

Browse Source 
Fixes #554
This commit is contained in:
Alessandro Arzilli 2016-05-29 21:11:00 +02:00 committed by Derek Parker
parent fa1db367fe
commit 5933a0f48f
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proc/mem.go
View File

@ -14,7 +14,7 @@ type memCache struct {
}
func (m *memCache) contains(addr uintptr, size int) bool {
return addr >= m.cacheAddr && (addr+uintptr(size)) <= (m.cacheAddr+uintptr(len(m.cache)))
return addr >= m.cacheAddr && addr <= (m.cacheAddr+uintptr(len(m.cache) - size))
}
func (m *memCache) readMemory(addr uintptr, size int) (data []byte, err error) {

9
proc/proc_test.go
View File

@ -1741,3 +1741,12 @@ func TestIssue462(t *testing.T) {
assertNoError(err, t, "Stacktrace()")
})
}
func TestIssue554(t *testing.T) {
// unsigned integer overflow in proc.(*memCache).contains was
// causing it to always return true for address 0xffffffffffffffff
mem := memCache{0x20, make([]byte, 100), nil}
if mem.contains(0xffffffffffffffff, 40) {
t.Fatalf("should be false")
}
}