PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: fix issue on Windows when launching process while detached (#3867)

Browse Source 
When the Delve instance is running in a detached state and it launches
a process an additional child conhost.exe process will be created, we
should detach from it.

Fixes #3864
This commit is contained in:
Alessandro Arzilli 2024-11-26 20:45:46 +01:00 committed by GitHub
parent 5c12831340
commit 5d82dc10dc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/proc/native/proc_windows.go
View File

@ -373,6 +373,17 @@ func (procgrp *processGroup) waitForDebugEvent(flags waitForDebugEventFlags) (th
// This is a fake process group and waitForDebugEvent has been called // This is a fake process group and waitForDebugEvent has been called
// just after attach/launch, finish configuring the root process. // just after attach/launch, finish configuring the root process.
dbp = procgrp.procs[0] dbp = procgrp.procs[0]
if debugEvent.ProcessId != uint32(dbp.pid) {
// When launching a new process while we are in detached state also
// creates a conhost.exe child process. This is that process and we
// need to detach from it.
// See issue #3864.
err := _DebugActiveProcessStop(debugEvent.ProcessId)
if err != nil {
return 0, err
}
continue
}
} else { } else {
// Add new child process // Add new child process
dbp = newChildProcess(procgrp.procs[0], int(debugEvent.ProcessId)) dbp = newChildProcess(procgrp.procs[0], int(debugEvent.ProcessId))