PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc/gdbserial: disable lldb backend on windows (#819)

Browse Source 
Lldb-server does not currently support windows/amd64 (it's in
development). And delve's native backend seems to work well on windows.
Disable the lldb backend on windows for now.

Fixes #817
This commit is contained in:
Alessandro Arzilli 2017-05-04 19:43:53 +02:00 committed by Derek Parker
parent dcf51a5032
commit 76ce11cffb
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/proc/gdbserial/gdbserver.go
View File

@ -292,13 +292,20 @@ func unusedPort() string {
const debugserverExecutable = "/Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver" const debugserverExecutable = "/Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver"
var ErrUnsupportedOS = errors.New("lldb backend not supported on windows")
// LLDBLaunch starts an instance of lldb-server and connects to it, asking // LLDBLaunch starts an instance of lldb-server and connects to it, asking
// it to launch the specified target program with the specified arguments // it to launch the specified target program with the specified arguments
// (cmd) on the specified directory wd. // (cmd) on the specified directory wd.
func LLDBLaunch(cmd []string, wd string) (*Process, error) { func LLDBLaunch(cmd []string, wd string) (*Process, error) {
// check that the argument to Launch is an executable file switch runtime.GOOS {
if fi, staterr := os.Stat(cmd[0]); staterr == nil && (fi.Mode()&0111) == 0 { case "windows":
return nil, proc.NotExecutableErr return nil, ErrUnsupportedOS
default:
// check that the argument to Launch is an executable file
if fi, staterr := os.Stat(cmd[0]); staterr == nil && (fi.Mode()&0111) == 0 {
return nil, proc.NotExecutableErr
}
} }
port := unusedPort() port := unusedPort()
@ -354,6 +361,10 @@ func LLDBLaunch(cmd []string, wd string) (*Process, error) {
// for some stubs that do not provide an automated way of determining it // for some stubs that do not provide an automated way of determining it
// (for example debugserver). // (for example debugserver).
func LLDBAttach(pid int, path string) (*Process, error) { func LLDBAttach(pid int, path string) (*Process, error) {
if runtime.GOOS == "windows" {
return nil, ErrUnsupportedOS
}
port := unusedPort() port := unusedPort()
isDebugserver := false isDebugserver := false
var proc *exec.Cmd var proc *exec.Cmd
@ -921,8 +932,8 @@ func (t *Thread) Blocked() bool {
func (p *Process) loadGInstr() []byte { func (p *Process) loadGInstr() []byte {
switch p.bi.GOOS { switch p.bi.GOOS {
case "windows": case "windows":
//TODO(aarzilli): implement // mov rcx, QWORD PTR gs:0x28
panic("not implemented") return []byte{0x65, 0x48, 0x8b, 0x0c, 0x25, 0x28, 0x00, 0x00, 0x00}
case "linux": case "linux":
switch p.bi.Arch.GStructOffset() { switch p.bi.Arch.GStructOffset() {
case 0xfffffffffffffff8, 0x0: case 0xfffffffffffffff8, 0x0: