PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: limit iteration depth of (*G).UserCurrent (#2135)

Browse Source 
Limit the iteration depth of proc.(*G).UserCurrent so that it doesn't
keep going forever if the stack trace is not valid.

Fixes #2119
This commit is contained in:
Alessandro Arzilli 2020-08-18 02:18:34 +02:00 committed by GitHub
parent 5461acf361
commit 9c83866c72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/proc/variables.go
View File

@ -35,6 +35,8 @@ const (
maxFramePrefetchSize = 1 * 1024 * 1024 // Maximum prefetch size for a stack frame
maxMapBucketsFactor = 100 // Maximum numbers of map buckets to read for every requested map entry when loading variables through (*EvalScope).LocalVariables and (*EvalScope).FunctionArguments.
maxGoroutineUserCurrentDepth = 30 // Maximum depth used by (*G).UserCurrent to search its location
)
type floatSpecial uint8
@ -487,7 +489,7 @@ func (g *G) UserCurrent() Location {
if err != nil {
return g.CurrentLoc
}
for it.Next() {
for count := 0; it.Next() && count < maxGoroutineUserCurrentDepth; count++ {
frame := it.Frame()
if frame.Call.Fn != nil {
name := frame.Call.Fn.Name