proc: fix automatic breakpoints visibility (#3300)

Unrecovered-panic and fatal-throw were no longer part of the breakpoint
list because starting in 37e44bf they were created before the logical
breakpoints map was switched to the logical breakpoints map of the
target group.

pkg/proc/target.go

@@ -193,6 +193,7 @@ func (grp *TargetGroup) newTarget(p ProcessInternal, pid int, currentThread Thre
 	g, _ := GetG(currentThread)
 	t.selectedGoroutine = g
 
+	t.Breakpoints().Logical = grp.LogicalBreakpoints
 	t.createUnrecoveredPanicBreakpoint()
 	t.createFatalThrowBreakpoint()
 	t.createPluginOpenBreakpoint()

pkg/proc/target_group.go

@@ -108,7 +108,6 @@ func (grp *TargetGroup) addTarget(p ProcessInternal, pid int, currentThread Thre
 	if grp.Selected == nil {
 		grp.Selected = t
 	}
-	t.Breakpoints().Logical = grp.LogicalBreakpoints
 	logger := logflags.DebuggerLogger()
 	for _, lbp := range grp.LogicalBreakpoints {
 		if lbp.LogicalID < 0 {

service/test/integration2_test.go

@@ -23,6 +23,7 @@ import (
 
 	"github.com/go-delve/delve/pkg/goversion"
 	"github.com/go-delve/delve/pkg/logflags"
+	"github.com/go-delve/delve/pkg/proc"
 	"github.com/go-delve/delve/service"
 	"github.com/go-delve/delve/service/api"
 	"github.com/go-delve/delve/service/rpc2"
@@ -2970,3 +2971,23 @@ func TestClientServer_createBreakpointWithID(t *testing.T) {
 		}
 	})
 }
+
+func TestClientServer_autoBreakpoints(t *testing.T) {
+	// Check that unrecoverd-panic and fatal-throw breakpoints are visible in
+	// the breakpoint list.
+	protest.AllowRecording(t)
+	withTestClient2("math", t, func(c service.Client) {
+		bps, err := c.ListBreakpoints(false)
+		assertNoError(err, t, "ListBreakpoints")
+		n := 0
+		for _, bp := range bps {
+			t.Log(bp)
+			if bp.Name == proc.UnrecoveredPanic || bp.Name == proc.FatalThrow {
+				n++
+			}
+		}
+		if n != 2 {
+			t.Error("automatic breakpoints not found")
+		}
+	})
+}