PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: do not ignore error return of funcCallEvalFuncExpr (#3850)

Browse Source 
This is probably the cause of the panic such as in issue #3848 and
other similar issues, it is hard to be sure because we never get a
proper reproducer but judging from the stack traces it should be this.
Also it doesn't affect versions of Go that have the debug pinner.

Fixes #3848
This commit is contained in:
Alessandro Arzilli 2024-11-06 19:27:44 +01:00 committed by GitHub
parent 50518504e1
commit b16e12fde7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/proc/fncall.go
View File

@ -981,7 +981,10 @@ func callInjectionComplete2(callScope *EvalScope, bi *BinaryInfo, fncall *functi
func (scope *EvalScope) evalCallInjectionSetTarget(op *evalop.CallInjectionSetTarget, stack *evalStack, thread Thread) { func (scope *EvalScope) evalCallInjectionSetTarget(op *evalop.CallInjectionSetTarget, stack *evalStack, thread Thread) {
fncall := stack.fncallPeek() fncall := stack.fncallPeek()
if !fncall.hasDebugPinner && (fncall.fn == nil || fncall.receiver != nil || fncall.closureAddr != 0) { if !fncall.hasDebugPinner && (fncall.fn == nil || fncall.receiver != nil || fncall.closureAddr != 0) {
funcCallEvalFuncExpr(scope, stack, fncall) stack.err = funcCallEvalFuncExpr(scope, stack, fncall)
if stack.err != nil {
return
}
} }
stack.pop() // target function, consumed by funcCallEvalFuncExpr either above or in evalop.CallInjectionStart stack.pop() // target function, consumed by funcCallEvalFuncExpr either above or in evalop.CallInjectionStart