PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

_scripts: Update staticcheck (#3270)

Browse Source
This commit is contained in:
Alessandro Arzilli 2023-02-14 18:36:00 +01:00 committed by GitHub
parent 95e33edf53
commit bc5c0d4a9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
_scripts/test_linux.sh
View File

@ -44,7 +44,7 @@ GOPATH=$(pwd)/go
export GOPATH export GOPATH
export PATH=$PATH:$GOROOT/bin:$GOPATH/bin export PATH=$PATH:$GOROOT/bin:$GOPATH/bin
go version go version
go install honnef.co/go/tools/cmd/staticcheck@2022.1.2 || true go install honnef.co/go/tools/cmd/staticcheck@2023.1 || true
uname -a uname -a
echo "$PATH" echo "$PATH"

4
cmd/dlv/dlv_test.go
View File

@ -1311,10 +1311,6 @@ func TestStaticcheck(t *testing.T) {
if err != nil { if err != nil {
t.Skip("staticcheck not installed") t.Skip("staticcheck not installed")
} }
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 20) {
//TODO(aarzilli): remove this when there is a version of staticcheck that can support go1.20
t.Skip("staticcheck does not support go1.20 currently")
}
// default checks minus SA1019 which complains about deprecated identifiers, which change between versions of Go. // default checks minus SA1019 which complains about deprecated identifiers, which change between versions of Go.
args := []string{"-tests=false", "-checks=all,-SA1019,-ST1000,-ST1003,-ST1016,-S1021,-ST1023", "github.com/go-delve/delve/..."} args := []string{"-tests=false", "-checks=all,-SA1019,-ST1000,-ST1003,-ST1016,-S1021,-ST1023", "github.com/go-delve/delve/..."}
// * SA1019 is disabled because new deprecations get added on every version // * SA1019 is disabled because new deprecations get added on every version