PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make.go: do not recodesign when rebuilding (#3639)

Browse Source
This commit is contained in:
ardnew 2024-01-19 13:51:22 -06:00 committed by GitHub
parent 1b201c3184
commit dab870bd96
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
_scripts/make.go
View File

@ -2,6 +2,7 @@ package main
import (
"fmt"
"io"
"log"
"os"
"os/exec"
@ -54,7 +55,7 @@ func NewMakeCommands() *cobra.Command {
} else {
execute("go", "build", "-ldflags", "-extldflags -static", tagFlags(), buildFlags(), DelveMainPackagePath)
}
if runtime.GOOS == "darwin" && os.Getenv("CERT") != "" && canMacnative() {
if runtime.GOOS == "darwin" && os.Getenv("CERT") != "" && canMacnative() && !isCodesigned("./dlv") {
codesign("./dlv")
}
},
@ -70,7 +71,7 @@ func NewMakeCommands() *cobra.Command {
Short: "Installs delve",
Run: func(cmd *cobra.Command, args []string) {
execute("go", "install", tagFlags(), buildFlags(), DelveMainPackagePath)
if runtime.GOOS == "darwin" && os.Getenv("CERT") != "" && canMacnative() {
if runtime.GOOS == "darwin" && os.Getenv("CERT") != "" && canMacnative() && !isCodesigned(installedExecutablePath()) {
codesign(installedExecutablePath())
}
},
@ -225,6 +226,15 @@ func getoutput(cmd string, args ...interface{}) string {
return string(out)
}
func isCodesigned(path string) bool {
x := exec.Command("codesign", "--verify", path)
x.Stdout = io.Discard
x.Stderr = io.Discard
x.Env = os.Environ()
err := x.Run()
return err == nil && x.ProcessState != nil && x.ProcessState.Success()
}
func codesign(path string) {
execute("codesign", "-s", os.Getenv("CERT"), path)
}