PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc/test: enable TestCgoStacktrace2 (#2194)

Browse Source 
Due to a missing check TestCgoStacktrace2 didn't actually check
anything. Enable it and then skip it on linux/386 and linux/arm64 where
it's broken.

Co-authored-by: a <a@kra>
This commit is contained in:
Alessandro Arzilli 2020-10-13 00:04:32 +02:00 committed by GitHub
parent 1374962f72
commit db716e4678
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Documentation/backend_test_health.md
View File

@ -1,9 +1,10 @@
Tests skipped by each supported backend:
* 386 skipped = 1.4% (2/145)
* 2 broken - cgo stacktraces
* arm64 skipped = 2.1% (3/145)
* 386 skipped = 2.1% (3/145)
* 1 broken
* 2 broken - cgo stacktraces
* arm64 skipped = 2.8% (4/145)
* 2 broken
* 1 broken - global variable symbolication
* 1 broken - reading defers
* darwin/lldb skipped = 0.69% (1/145)

7
pkg/proc/proc_test.go
View File

@ -4519,6 +4519,8 @@ func TestIssue1615(t *testing.T) {
func TestCgoStacktrace2(t *testing.T) {
skipOn(t, "upstream issue", "windows")
skipOn(t, "broken", "386")
skipOn(t, "broken", "arm64")
protest.MustHaveCgo(t)
// If a panic happens during cgo execution the stacktrace should show the C
// function that caused the problem.
@ -4527,7 +4529,10 @@ func TestCgoStacktrace2(t *testing.T) {
frames, err := proc.ThreadStacktrace(p.CurrentThread(), 100)
assertNoError(err, t, "Stacktrace()")
logStacktrace(t, p.BinInfo(), frames)
stacktraceCheck(t, []string{"C.sigsegv", "C.testfn", "main.main"}, frames)
m := stacktraceCheck(t, []string{"C.sigsegv", "C.testfn", "main.main"}, frames)
if m == nil {
t.Fatal("see previous loglines")
}
})
}