PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: use signed comparison when searching image for module data (#2621)

Browse Source 
StaticBase is the difference between the entry point declared in the
image file and the entry point as loaded in memory, since this
difference could be a negative number we have to use a signed
comparison when searching for a mapping.

Causes intermittent test failures on windows when resolving interface
types for position independent executables.

Fixes #2620
This commit is contained in:
Alessandro Arzilli 2021-07-26 17:40:12 +02:00 committed by GitHub
parent 150ef04177
commit e9b20d5ee1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/proc/bininfo.go
View File

@ -722,10 +722,10 @@ func (bi *BinaryInfo) moduleDataToImage(md *moduleData) *Image {
// Try searching for the image with the closest address preceding md.text
var so *Image
for i := range bi.Images {
if bi.Images[i].StaticBase > md.text {
if int64(bi.Images[i].StaticBase) > int64(md.text) {
continue
}
if so == nil || bi.Images[i].StaticBase > so.StaticBase {
if so == nil || int64(bi.Images[i].StaticBase) > int64(so.StaticBase) {
so = bi.Images[i]
}
}