Continuous Integration cleanup (#2369)

- remove github workflow for testing macOS/amd64 that is now covered by
  TeamCity
- fix DeepSource glob patterns to actually match what they are intended
  to match (did the interpretation change?)
- disable some cgo tests on darwin/arm64
This commit is contained in:
Alessandro Arzilli 2021-03-08 18:35:56 +01:00 committed by GitHub
parent 4364c728f0
commit f0ed4a71e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 17 additions and 19 deletions

@ -2,7 +2,7 @@ version = 1
test_patterns = ["**/*_test.go"]
exclude_patterns = ["vendor", "_fixtures", "_scripts"]
exclude_patterns = ["vendor/**", "_fixtures/**", "_scripts/**"]
[[analyzers]]
name = "go"

@ -1,18 +0,0 @@
name: Delve CI
on: [push, pull_request]
jobs:
build:
runs-on: ${{matrix.os}}
strategy:
matrix:
include:
- go: 1.15
os: macos-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v1
with:
go-version: ${{matrix.go}}
- run: go run _scripts/make.go test

@ -7,6 +7,8 @@ Tests skipped by each supported backend:
* 2 broken
* 1 broken - cgo stacktraces
* 1 broken - global variable symbolication
* darwin/arm64 skipped = 0.68% (1/148)
* 1 broken - cgo stacktraces
* darwin/lldb skipped = 0.68% (1/148)
* 1 upstream issue
* freebsd skipped = 8.1% (12/148)

@ -837,6 +837,8 @@ func TestCGONext(t *testing.T) {
}
protest.MustHaveCgo(t)
skipOn(t, "broken - cgo stacktraces", "darwin", "arm64")
protest.AllowRecording(t)
withTestProcess("cgotest", t, func(p *proc.Target, fixture protest.Fixture) {
setFunctionBreakpoint(p, t, "main.main")
@ -943,6 +945,8 @@ func stackMatch(stack []loc, locations []proc.Stackframe, skipRuntime bool) bool
}
func TestStacktraceGoroutine(t *testing.T) {
skipOn(t, "broken - cgo stacktraces", "darwin", "arm64")
mainStack := []loc{{14, "main.stacktraceme"}, {29, "main.main"}}
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 11) {
mainStack[0].line = 15

@ -716,6 +716,9 @@ func Test1ClientServer_SetVariable(t *testing.T) {
}
func Test1ClientServer_FullStacktrace(t *testing.T) {
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
t.Skip("cgo doesn't work on darwin/arm64")
}
withTestClient1("goroutinestackprog", t, func(c *rpc1.RPCClient) {
_, err := c.CreateBreakpoint(&api.Breakpoint{FunctionName: "main.stacktraceme", Line: -1})
assertNoError(err, t, "CreateBreakpoint()")

@ -911,6 +911,9 @@ func TestClientServer_SetVariable(t *testing.T) {
func TestClientServer_FullStacktrace(t *testing.T) {
protest.AllowRecording(t)
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
t.Skip("cgo doesn't work on darwin/arm64")
}
withTestClient2("goroutinestackprog", t, func(c service.Client) {
_, err := c.CreateBreakpoint(&api.Breakpoint{FunctionName: "main.stacktraceme", Line: -1})
assertNoError(err, t, "CreateBreakpoint()")

@ -1564,6 +1564,10 @@ func TestCgoEval(t *testing.T) {
{"v_align_check[90]", false, "align_check {a: 90, b: 90}", "align_check {a: 90, b: 90}", "align_check", nil},
}
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
t.Skip("cgo doesn't work on darwin/arm64")
}
protest.AllowRecording(t)
withTestProcess("testvariablescgo/", t, func(p *proc.Target, fixture protest.Fixture) {
assertNoError(p.Continue(), t, "Continue() returned an error")