From f1edc45f7518ab976b5ab3e26775f8c17707be66 Mon Sep 17 00:00:00 2001 From: Suzy Mueller Date: Fri, 23 Jul 2021 11:12:57 -0600 Subject: [PATCH] service/dap: disable TestFatalThrowBreakpoint for Go 1.17 (#2614) * service/dap: disable TestFatalThrowBreakpoint for Go 1.17 --- service/dap/server_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/service/dap/server_test.go b/service/dap/server_test.go index 63422f38..8e1b9903 100644 --- a/service/dap/server_test.go +++ b/service/dap/server_test.go @@ -3689,6 +3689,10 @@ func TestPanicBreakpointOnNext(t *testing.T) { } func TestFatalThrowBreakpoint(t *testing.T) { + // This is not currently flaky for Go 1.17 see https://github.com/golang/go/issues/46425. + if goversion.VersionAfterOrEqual(runtime.Version(), 1, 17) { + t.Skip() + } runTest(t, "fatalerror", func(client *daptest.Client, fixture protest.Fixture) { runDebugSessionWithBPs(t, client, "launch", // Launch @@ -4574,7 +4578,6 @@ func TestOptionalNotYetImplementedResponses(t *testing.T) { client.RestartRequest() expectNotYetImplemented("restart") - client.SetExpressionRequest() expectNotYetImplemented("setExpression")