PenaDevops/delve
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

terminal: fix nil pointer dereference when printing tracepoints (#2071)

Browse Source 
This issue causes a failure of TestTracePid that was observed in CI:

https://travis-ci.com/github/go-delve/delve/jobs/343053383

I'm not sure what causes it in this particular instance but there are
several ways in which a thread stopped at a breakpoint might have a
BreakpointInfo == nil field (see variable withBreakpointInfo in
debugger.Debugger.Command).
This commit is contained in:
Alessandro Arzilli 2020-06-03 19:54:07 +02:00 committed by GitHub
parent 04a0891913
commit fecf14bd19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/terminal/command.go
View File

@ -2269,7 +2269,7 @@ func printTracepoint(th *api.Thread, bpname string, fn *api.Function, args strin
fmt.Fprintf(os.Stderr, " => (%s)\n", strings.Join(retVals, ",")) fmt.Fprintf(os.Stderr, " => (%s)\n", strings.Join(retVals, ","))
} }
if th.Breakpoint.TraceReturn || !hasReturnValue { if th.Breakpoint.TraceReturn || !hasReturnValue {
if th.BreakpointInfo.Stacktrace != nil { if th.BreakpointInfo != nil && th.BreakpointInfo.Stacktrace != nil {
fmt.Fprintf(os.Stderr, "\tStack:\n") fmt.Fprintf(os.Stderr, "\tStack:\n")
printStack(os.Stderr, th.BreakpointInfo.Stacktrace, "\t\t", false) printStack(os.Stderr, th.BreakpointInfo.Stacktrace, "\t\t", false)
} }