Eli Bendersky
a83554863f
service/dap: clean shutdown sequence in server ( #1889 )
...
Using a stop channel to signal clean shutdown to the server's
goroutines. Also updates the tests to trigger disconnectChan.
This helps avoid spurious error logs when the client disconnects, when
Ctrl+C is pressed, etc.
2020-02-26 20:45:48 -08:00
Eli Bendersky
23b8e59ab9
service/dap: Add panic guard to DAP handlers ( #1895 )
...
* Panic guard for DAP request handling
* Use GetSeq
* Re-vendor new version of go-dap
* Remove comment
* Update error message
* Reuse er.Message in Format
2020-02-25 21:00:54 -08:00
Eli Bendersky
7f14f6ab11
service/dap: avoid hardcoded []byte slices in DAP tests ( #1881 )
...
* Remove hardcoded tests
* Cleanup - consistent naming, simplify some code, remove unused func
* Address review comments
* Add Seq checks back
* Address more review comments
* Remove hardcoded tests
* Cleanup - consistent naming, simplify some code, remove unused func
* Address review comments
* Add Seq checks back
* Address more review comments
* Make more consistent
* More consistency
* Simplify Except* methods with a helper
Mark t.Helper() where appropriate
2020-02-24 09:36:34 -08:00
Hyang-Ah Hana Kim
44c644ccf2
service/dap: minor cosmetic changes ( #1882 )
...
- Move package doc comments so they are recognized as package doc.
- Use t.Helper when appropriate.
2020-02-21 09:05:30 -08:00
polinasok
fbc4623c08
service/dap: Initial implementation for 'dlv dap' ( #1858 )
...
* Initial implementation for 'dlv dap'
* Fix Travis and AppVeyor failures
* Address review comments
* Address review comments
* Regenrate documentation
* Replace dap server printfs with log.Error
* Update 'dap log'
* Fix typos
* Revert logflags changes that got mixed in by accident
2020-02-15 11:52:53 -08:00
