Commit Graph

69 Commits

Author SHA1 Message Date
aarzilli
79a0e216ab proc: add iface.(data) syntax to access concrete value of an interface
With this syntax users do not need to type the concrete type of an
interface variable to access its contents. This also sidesteps the
problem where the serialization of a type by go/printer is different
from the one used for debug_info type names.

Updates #1328
2018-09-27 14:09:26 -07:00
chainhelen
0c86f2619d documentation/cli: fix typo
format `whatis <expression>`
2018-09-24 10:25:15 -07:00
Dmitry Ishmaev
23475717ff Documentation: Add Sublime plugin (#1352) 2018-09-24 10:24:49 -07:00
aarzilli
4fea15832f Documentation: mention that interfaces can also not be loaded
An interface with a children that has onlyAddr set to true was not
loaded due to the depth limit having been reached.
2018-09-18 13:10:50 -07:00
Seth Bromberger
5e6b7997e1 Update install.md 2018-09-18 10:22:48 -07:00
Seth Bromberger
654a9a5b5e Update install.md
Explicit build instructions to avoid #1342.
2018-09-18 10:22:48 -07:00
aarzilli
dcf9d4fc6b terminal: refactor edit/list to share getLocation code
Refactors edit and list so that they use the same code to get the
current location and also both accept a locspec as an argument.
2018-08-31 11:16:42 -07:00
aarzilli
d81d6702e0 terminal: updated call description
Updated call description to reflect current limitations.
2018-08-16 12:44:02 -07:00
Florin Pățan
a117cf2c00 Documentation 2018-08-07 17:56:50 -07:00
Ben Cotterell
22af38364b Add an edit command
Which I miss from gdb-- it's nice to be able to open where you are in
your editor where you're already working on the project you're
debugging.
2018-07-31 13:22:48 -07:00
Ramya Achutha Rao
c8fcc3c5b2 Fix casing on delve 2018-07-23 10:12:05 -07:00
Ramya Achutha Rao
e6ce7d4120 Add docs on detaching 2018-07-23 10:12:05 -07:00
aarzilli
2925c0310a *: function call injection for go 1.11
Implements the function call injection protocol introduced in go 1.11
by https://go-review.googlesource.com/c/go/+/109699.

This is only the basic support, see TODO comments in pkg/proc/fncall.go
for a list of missing features.

Updates #119
2018-07-13 13:37:54 -07:00
aarzilli
2309f728c1 proc,service,terminal: propagate g.startpc
Adds StartPC to proc.G, StartLoc to api.Goroutine and show the start
location in the command line client when appropriate.

Updates #1104
2018-07-09 17:20:55 -07:00
aarzilli
78377cad9d Documentation: better documentation menu, add guide to writing a client
* Adds some links to the more relevant documentation pages on the main
  README.md
* Adds a document informally describing how to write a client of delve
* Adds link to slides describing the architecture of delve
2018-07-02 09:35:27 -07:00
aarzilli
9a216211d3 proc,terminal,service: let headless instances run without connected clients
This pull request makes several changes to delve to allow headless
instancess that are started with the --accept-multiclient flag to
keep running even if there is no connected client. Specifically:

1. Makes a headless instance started with --accept-multiclient quit
    after one of the clients sends a Detach request (previously they
    would never ever quit, which was a bug).
2. Changes proc/gdbserial and proc/native so that they mark the
    Process as exited after they detach, even if they did not kill the
    process during detach. This prevents bugs such as #1231 where we
    attempt to manipulate a target process after we detached from it.
3. On non --accept-multiclient instances do not kill the target
    process unless we started it or the client specifically requests
    it (previously if the client did not Detach before closing the
    connection we would kill the target process unconditionally)
4. Add a -c option to the quit command that detaches from the
    headless server after restarting the target.
5. Change terminal so that, when attached to --accept-multiclient,
    pressing ^C will prompt the user to either disconnect from the
    server or pause the target process. Also extend the exit prompt to
    ask if the user wants to keep the headless server running.

Implements #245, #952, #1159, #1231
2018-06-26 10:32:40 -07:00
aarzilli
2a2d1040e9 proc: allow "package/path".varname syntax
If the application being debugged imports two packages with the same
name (but different paths) there was no way to disambiguate the two,
since the character '/' can not appear inside a go identifier.

By allowing users to use a string literal as the package name a package
path can be specified.
2018-06-14 09:29:23 -07:00
aarzilli
454491ce86 service,logflags: log all RPC messages
We occasionally receive bug reports from users of VSCode-go and GoLand.
GoLand has its own way of capturing the packet exchange between itself
and delve but VSCode-go (supposedly) doesn't.
So far this hasn't been a problem since all bug reports were obvious
bugs on the plugin or easy to reproduce without VSCode-go, but it might
be helpful in the future to have a way to log the packet exchange
between dlv and a frontend.

This commit adds a --log-output option to enable logging of all rpc
messages and changes service/rpccommon accordingly.
2018-06-14 09:27:38 -07:00
aarzilli
5155ef047f proc,dwarf/line: support is_stmt and prologue_end flags
Go1.11 uses the is_stmt flag of .debug_line to communicate which
assembly instructions are good places for breakpoints, we should
respect this flag.

These changes were introduced by:
* https://go-review.googlesource.com/c/go/+/102435/

Additionally when setting next breakpoints ignore all PC addresses that
belong to the same line as the one currently under at the cursor. This
matches the behavior of gdb and avoids stopping multiple times at the
heading line of a for statement with go1.11.

Change: https://go-review.googlesource.com/c/go/+/110416 adds the
prologue_end flag to the .debug_line section to communicate the end of
the stack-split prologue. We should use it instead of pattern matching
the disassembly when available.

Fixes #550

type of interfaces
'c7cde8b'.
2018-06-11 11:09:02 -07:00
Chandrashekhara A
3c794eb306 command/terminal: Printing stack trace of all the goroutines (#1212)
Add -t falg to "goroutines" command. For example, "goroutines -t" will
print all the goroutines along with the stack trace.
2018-05-22 11:02:43 -07:00
aarzilli
8ce88095c6 cmd/dlv: Revert 4e177b, use new flag name for debug logging options
Previously to 4e177bb99acc511897f9cdbfc6cbc50d92ae4725 it was possible
to use --log without arguments to enable logging, this commit reenables
that use case.

The new functionality of the --log flag moved to a new flag name
--logx.

Fixes #1188
2018-04-26 09:45:52 -07:00
aarzilli
f27c91ba3c Documentation: automatically check that documentation is up to date
Since we always forget to update the documentation lets check this
automatically.
2018-04-18 10:48:55 -07:00
Derek Parker
38ddb22b68 Documentation: generate new docs (#1185) 2018-04-18 08:46:55 +02:00
Patrick
db435c184e Update install.md
I found this issue (https://github.com/derekparker/delve/issues/514) where user alexbrainman gave a very helpful answer. Adding this to the official install-guide might help a lot of users.
2018-03-28 12:15:23 -04:00
Martin Tournoij
5d59d1f6cb Mention that vim-go now supports Delve integration 2018-03-27 12:37:45 -04:00
Josh Soref
1d3b41f64e all: Spelling 2018-03-20 11:05:35 +01:00
Giuseppe
2ba27af6e7 Documentation: make install must run in workspace 2018-03-15 17:56:39 -07:00
aarzilli
fbd152f6a8 Documentation: remove homebrew as an install method
The formula is broken and produces an endless stream of duplicate bug
reports yet nobody steps up to fix it. Using the formula isn't
necessary and hasn't been in almost a year, the maintainers of delve
aren't using it and the original maintainer of the formula vacated.
2018-03-05 10:10:17 -08:00
Graham King
0b41a525f6 Documentation: Document passing flags with --. (#1096)
Document how to pass flags to the cli program being debugged.
2018-01-25 11:59:02 -08:00
Lucas Molas
c38d6755f0 Documentation: update usage docs (#1095) 2018-01-25 11:54:00 -08:00
Matthew Taylor
3d42ff0ad8 Documentation: renamed gogland to goland and removed beta status 2018-01-12 13:33:07 +01:00
Chad Whitacre
e949a262f1 Documentation: Fix possessive (#1072) 2018-01-07 13:54:21 -08:00
Derek Parker
01f5b3c8d0 Documentation: Improve link layout, add getting started doc (#1064)
Improve the link ordering for the main README and add a
"Getting Started" doc with basic usage information for new users.
2018-01-04 04:50:44 -08:00
Victor Titov
690e3fff3f Documentation: add -u flag to go get 2018-01-02 05:07:12 -08:00
aarzilli
17bd4b52e8 pkg/terminal: -offsets flag for stack command
Prints the frame and frame pointer offsets for each frame.
2017-11-28 11:00:53 -08:00
aarzilli
8f16b371d1 proc/eval: support more type casts
* string to []rune
* string to []byte
* []rune to string
* []byte to string
* any pointer to uintptr

The string, []rune, []byte conversion pairs aligns this to the go
language.
The pointer -> uintptr conversion pair is symmetric to the uintptr ->
pointer that we already have.

Also lets the user specify any size for byte array types instead of
just the ones already used by the program, this can be used to read
arbitrary memory.

Fixes #548, #867
2017-10-25 13:20:25 +02:00
aarzilli
48288edd18 terminal: add config command
Fixes #927, #644
2017-09-08 10:27:32 -07:00
aarzilli
c2092d1669 terminal: implement whatis command
Implements #596
2017-09-08 10:26:19 -07:00
aarzilli
dc22db2b42 Documentation: After the go1.9 support PR delve no longer builds on <1.7. 2017-08-09 17:07:11 -06:00
Tao Zhou
fead9fe0f8 doc/cli: fix clear-checkpoint command typo 2017-08-07 15:58:20 -06:00
Joey Geiger
7214ffe20e Add breakpoint init functions suggestion
This is a "fix" for the issue of being unable to see the source when setting a breakpoint on main.init.

Fixes #922
2017-08-01 11:21:06 -06:00
aarzilli
2ad9ce6fe3 proc: lexical block support
Fixes #106
2017-08-01 11:20:25 -06:00
Sebastian Dahlgren
5cd2ac1d49 docs: Add vim-delve and clean up page (#917) 2017-07-18 12:56:42 -06:00
Alessandro Arzilli
a90893f532 path/to/binary is the required argument (#847 fixed) (#884)
* cmd: include replay command in docs even if rr is not installed.

* path/to/binary is the required argument

Replaces #847
2017-06-20 10:36:07 -07:00
Jacob Van Order
311a53f80b Update install.md (#882) 2017-06-19 12:51:16 -07:00
custa
dbc1ce1e5b typo, fix and run 'go run ./scripts/gen-cli-docs.go' (#848) 2017-06-05 14:20:10 -07:00
Alessandro Arzilli
a843f7944e proc/gdbserial: mozilla rr support (#804)
Implements #727
2017-05-05 15:17:52 -07:00
Alessandro Arzilli
3a86b9fab4 documentation: updated macOS install instructions (#801) 2017-04-24 12:45:37 -07:00
Alessandro Arzilli
ecc2eb6da6 documentation: add gdlv to list of alternative UIs (#774) 2017-03-24 16:10:01 -07:00
Justin Clift
43aa55dee3 Add an entry for Gogland (#775) 2017-03-24 16:07:50 -07:00