polinasok
c94db60d27
service/dap: support evaluate requests with expressions and calls ( #2185 )
...
* Support evaluate request
* Fix failing tests
* Call support
* Remove debugger.CurrentThread() that got accidentally reintroduced during merge
* Address review comments
* Function to stringify stop reason
* Add resetHandlesForStop
* Handle stop inside call
* More tests
* Address review comments
* Check all threads to determine if call completed
* Fix test
* Fix test
* Fix test
* Address review comments
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-11-12 15:24:31 -08:00
polinasok
80d0c8e717
service/dap: support clearing breakpoints and setting breakpoint conditions ( #2188 )
...
* Support clearing breakpoints and setting conditions
* Return unverified breakpoints with errors
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-10-02 09:18:33 -07:00
polinasok
ec9765359a
service/dap: support next, stepIn and stepOut requests ( #2143 )
...
* Issue stopped event on runtime error when continuing
* Support next, stepIn and stepOut
* Refactor stop logic
* Explicitely set AllThreadsContinued
* Make DeepSource happy
* Respond to review comments
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-08-24 10:21:51 -07:00
polinasok
58ea3234ef
service/dap: Initial support for scopes and variables requests ( #2111 )
...
* Initial support for scopes and variables requests
* Add detailed variables test
* Address review comments
* Fix typo and redudant escaped characters
* Bug fix for uninitialized interfaces; no refs needed for 0-size vars
* Minor cosmetic tweaks
* Add incomplete loading test
* Make DeepSource happy
* Remove unnecessary t.Helper() calls
* Update broken test after merge
* Add missing return
* Rework test harness to abort testvariables2 before stack overflow
* Remove accidentally duplicated disconnet
* Test for invalid interface type with regex
* Drop testvariables3, clean up and test unreadable case
* Respond to review comments
* Make expectVar test helper less fragile
* Make DeepSource happy
* Use proc.LoadConfig directly
* Adjust test to avoid var count discrepency between Go 1.15 and earlier
* Make compound keys in a map unique for correct display
* Remove locals num check that will break if more vars are added
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-08-11 08:34:27 -07:00
polinasok
7e13791b4a
service/dap: Support stackTrace request ( #2093 )
...
* service/dap: Support stackTrace request
* Minor tweaks
* Address review comments
* Fix grammar
* Address review comments
* Address review comments
* Update comments
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-07-01 11:01:17 -07:00
polinasok
2f295f310d
service/dap: Add error handlers for unsupported and not-yet-supported requests ( #1918 )
...
* Add no-op handlers for unsupported requests
* Fix whitespace
* Add couple of missing unsupported requests
* More comments
* Separate errors for unsupported and not-yet-implemented requests.
* Fix go.mod/sum dependencies
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-05-01 12:24:44 -07:00
polinasok
5613cf151e
service/dap: Add support for threads request ( #1914 )
...
* Add support for threads request
* Address review comments
* Relax threads test condition
* Address review comments
* Clean up unnecessary newline
* Respond to review comment
Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
2020-03-10 12:29:06 -07:00
polinasok
f863be0a17
service/dap: Add support for debug and test modes ( #1901 )
...
* service/dap: Add support for debug and test modes
* Address code review comments
* Remove //dap comment
* OptFlags() => optfalgs()
* If mode => switch mode
2020-03-04 09:22:51 -08:00
Eli Bendersky
a83554863f
service/dap: clean shutdown sequence in server ( #1889 )
...
Using a stop channel to signal clean shutdown to the server's
goroutines. Also updates the tests to trigger disconnectChan.
This helps avoid spurious error logs when the client disconnects, when
Ctrl+C is pressed, etc.
2020-02-26 20:45:48 -08:00
Eli Bendersky
23b8e59ab9
service/dap: Add panic guard to DAP handlers ( #1895 )
...
* Panic guard for DAP request handling
* Use GetSeq
* Re-vendor new version of go-dap
* Remove comment
* Update error message
* Reuse er.Message in Format
2020-02-25 21:00:54 -08:00
Eli Bendersky
7f14f6ab11
service/dap: avoid hardcoded []byte slices in DAP tests ( #1881 )
...
* Remove hardcoded tests
* Cleanup - consistent naming, simplify some code, remove unused func
* Address review comments
* Add Seq checks back
* Address more review comments
* Remove hardcoded tests
* Cleanup - consistent naming, simplify some code, remove unused func
* Address review comments
* Add Seq checks back
* Address more review comments
* Make more consistent
* More consistency
* Simplify Except* methods with a helper
Mark t.Helper() where appropriate
2020-02-24 09:36:34 -08:00
Hyang-Ah Hana Kim
44c644ccf2
service/dap: minor cosmetic changes ( #1882 )
...
- Move package doc comments so they are recognized as package doc.
- Use t.Helper when appropriate.
2020-02-21 09:05:30 -08:00
polinasok
fbc4623c08
service/dap: Initial implementation for 'dlv dap' ( #1858 )
...
* Initial implementation for 'dlv dap'
* Fix Travis and AppVeyor failures
* Address review comments
* Address review comments
* Regenrate documentation
* Replace dap server printfs with log.Error
* Update 'dap log'
* Fix typos
* Revert logflags changes that got mixed in by accident
2020-02-15 11:52:53 -08:00
