b9d0ddd82c
A significant amount of time is spent generating the string representation for the proc.Registers object of each thread, since this field is rarely used (only when the Registers API is called) it should be generated on demand. Also by changing the internal representation of proc.Register to be closer to that of op.DwarfRegister it will help us implement #1838 (when Delve will need to be able to display the registers of an internal frame, which we currently represent using op.DwarfRegister objects). Benchmark before: BenchmarkConditionalBreakpoints-4 1 22292554301 ns/op Benchmark after: BenchmarkConditionalBreakpoints-4 1 17326345671 ns/op Reduces conditional breakpoint latency from 2.2ms to 1.7ms. Updates #1549, #1838
32 lines
993 B
Go
32 lines
993 B
Go
package proc
|
|
|
|
import (
|
|
"github.com/go-delve/delve/pkg/dwarf/frame"
|
|
"github.com/go-delve/delve/pkg/dwarf/op"
|
|
)
|
|
|
|
// Arch defines an interface for representing a
|
|
// CPU architecture.
|
|
type Arch interface {
|
|
PtrSize() int
|
|
MaxInstructionLength() int
|
|
AsmDecode(asmInst *AsmInstruction, mem []byte, regs Registers, memrw MemoryReadWriter, bi *BinaryInfo) error
|
|
Prologues() []opcodeSeq
|
|
BreakpointInstruction() []byte
|
|
BreakInstrMovesPC() bool
|
|
BreakpointSize() int
|
|
DerefTLS() bool
|
|
FixFrameUnwindContext(*frame.FrameContext, uint64, *BinaryInfo) *frame.FrameContext
|
|
SwitchStack(it *stackIterator, callFrameRegs *op.DwarfRegisters) bool
|
|
RegSize(uint64) int
|
|
RegistersToDwarfRegisters(uint64, Registers) op.DwarfRegisters
|
|
AddrAndStackRegsToDwarfRegisters(uint64, uint64, uint64, uint64, uint64) op.DwarfRegisters
|
|
DwarfRegisterToString(string, *op.DwarfRegister) string
|
|
}
|
|
|
|
const (
|
|
crosscall2SPOffsetBad = 0x8
|
|
crosscall2SPOffsetWindows = 0x118
|
|
crosscall2SPOffsetNonWindows = 0x58
|
|
)
|