delve/pkg
Alessandro Arzilli 4dc8aedc4d
proc/gdbserial: fix two protocol bugs (#2172)
During the testing of the core dump generation feature two bugs were
discovered in gdbserial:

1. we don't check that both bytes of the checksum are read, if the
   buffer only has one byte we can end up reading only one byte instead
   of two and the second byte will mess up the parsing of the next
   packet
2. binary encoded packets can start with an 'E' and not be errors, when
   using binary responses add an extra check for the lenght of the
   response before deciding that the response is an error.
   Unfortunately this encoding is inherently ambiguous (we can't
   distinguish a 3 byte response starting with 'E' from an error) so
   binary requests that lead to short responses should be avoided.

Testing this is complicated, they will be tested implicitly by the
upcoming core dump test.

Co-authored-by: a <a@kra>
2020-09-15 13:15:49 -07:00
..
astutil proc: simplify next/step/stepout condition code 2020-04-04 11:00:54 -07:00
config config: add option for printfile() line count (#2043) 2020-05-11 09:50:25 -07:00
dwarf dwarf/loclist,godwarf,proc: support DWARF version 5 loclists and debug_addr (#2097) 2020-08-17 17:19:46 -07:00
gobuild gobuild: pass-through stdout to 'go' command invocation (#2044) 2020-05-11 09:44:25 -07:00
goversion Travis-CI: bump Go version in test matrix 2020-08-17 10:25:01 +02:00
locspec cmd/dlv: Fix trace output (#2038) 2020-05-13 08:38:10 +02:00
logflags logflags: Add pid to server-listening-at message (#1885) 2020-03-09 10:14:34 -07:00
proc proc/gdbserial: fix two protocol bugs (#2172) 2020-09-15 13:15:49 -07:00
terminal terminal: add -size argument to examinemem command 2020-09-11 08:21:11 +02:00
version all: bump version and release notes 2020-07-29 21:59:07 +02:00