delve/service
Alessandro Arzilli f3e76238e3
proc: move breakpoint condition evaluation out of backends (#2628)
* proc: move breakpoint condition evaluation out of backends

Moves breakpoint condition evaluation from the point where breakpoints
are set, inside ContinueOnce, to (*Target).Continue.

This accomplishes three things:

1. the breakpoint evaluation method needs not be exported anymore
2. breakpoint condition evaluation can be done with a full scope,
   containing a Target object, something that wasn't possible before
   because ContinueOnce doesn't have access to the Target object.
3. moves breakpoint condition evaluation out of the critical section
   where some of the threads of the target process might be still
   running.

* proc/native: handle process death during stop() on Windows

It is possible that the thread dies while we are inside the stop()
function. This results in an Access is denied error being returned by
SuspendThread being called on threads that no longer exist.

Delay the reporting the error from SuspendThread until the end of
stop() and only report it if the thread still exists at that point.

Fixes flakyness with TestIssue1101 that was exacerbated by moving
breakpoint condition evaluation outside of the backends.
2021-08-09 10:16:24 -07:00
..
api *: Initial eBPF tracing support (#2625) 2021-07-31 17:16:26 +02:00
dap service/dap: fix race condition in TestContinueOnEntry (#2641) 2021-08-05 22:19:27 -07:00
debugger proc: move breakpoint condition evaluation out of backends (#2628) 2021-08-09 10:16:24 -07:00
internal/sameuser sameuser: log the uid/remoteUID when they are not matching (#2535) 2021-06-15 15:36:39 +02:00
rpc1 Go 1.17 support branch (#2451) 2021-07-08 08:47:53 -07:00
rpc2 *: Initial eBPF tracing support (#2625) 2021-07-31 17:16:26 +02:00
rpccommon dap: add sameuser check (#2494) 2021-05-19 10:29:05 -07:00
test proc: move breakpoint condition evaluation out of backends (#2628) 2021-08-09 10:16:24 -07:00
client.go terminal,service: Add filtering and grouping to goroutines command (#2504) 2021-07-01 11:25:33 -07:00
config.go cmd/dlv: Fix trace output (#2038) 2020-05-13 08:38:10 +02:00
listenerpipe.go cmd,service: in non-headless mode use an in-memory connection 2018-10-08 15:11:13 -07:00
rpccallback.go service: serialize calls to Command API (#2370) 2021-03-08 10:05:10 -08:00
server.go cmd,service: remove temporary def of Server interface in func 2018-10-09 07:56:48 -07:00