delve/service/debugger
Alessandro Arzilli f3e76238e3
proc: move breakpoint condition evaluation out of backends (#2628)
* proc: move breakpoint condition evaluation out of backends

Moves breakpoint condition evaluation from the point where breakpoints
are set, inside ContinueOnce, to (*Target).Continue.

This accomplishes three things:

1. the breakpoint evaluation method needs not be exported anymore
2. breakpoint condition evaluation can be done with a full scope,
   containing a Target object, something that wasn't possible before
   because ContinueOnce doesn't have access to the Target object.
3. moves breakpoint condition evaluation out of the critical section
   where some of the threads of the target process might be still
   running.

* proc/native: handle process death during stop() on Windows

It is possible that the thread dies while we are inside the stop()
function. This results in an Access is denied error being returned by
SuspendThread being called on threads that no longer exist.

Delay the reporting the error from SuspendThread until the end of
stop() and only report it if the thread still exists at that point.

Fixes flakyness with TestIssue1101 that was exacerbated by moving
breakpoint condition evaluation outside of the backends.
2021-08-09 10:16:24 -07:00
..
debugger_darwin.go Add support for Windows. 2016-01-20 19:06:31 -08:00
debugger_freebsd.go *: FreeBSD initial support (#1480) 2019-07-12 18:28:04 -07:00
debugger_linux.go debugger: make yama error more verbose 2018-08-20 10:37:04 -07:00
debugger_test.go *: Better error launching invalid binary format 2020-04-02 18:41:16 +02:00
debugger_unix_test.go service/debugger: Fix checking for CI 2020-04-14 21:02:38 +02:00
debugger_unix.go *: Better error launching invalid binary format 2020-04-02 18:41:16 +02:00
debugger_windows.go *: Better error launching invalid binary format 2020-04-02 18:41:16 +02:00
debugger.go proc: move breakpoint condition evaluation out of backends (#2628) 2021-08-09 10:16:24 -07:00