PenaSide/heruvym
3
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

added system varible to create ticket and added filter for get messages #12

Merged
skeris merged 2 commits from system into dev 2024-12-09 13:43:11 +00:00
Conversation 0 Commits 2 Files Changed 5 +58 -5
skeris commented 2024-12-09 12:39:54 +00:00
Owner
Copy Link
No description provided.
pasha1coil was assigned by skeris 2024-12-09 12:39:54 +00:00
skeris added 1 commit 2024-12-09 12:39:54 +00:00
skeris reviewed 2024-12-09 12:41:26 +00:00
internal/controllers/tickets/tickets.go Outdated
@ -319,0 +323,4 @@
var filtered []model.Message
for _, message := range result {
if !message.System { // исключаем системные сообщения
filtered = append(filtered, message)
skeris commented 2024-12-09 12:41:26 +00:00
Author
Owner
Copy Link

плохой вариант. надо запрос править, а не так отфильтровывать. а то страница списка сообщений может быть забита целиком системными и вот придёт фронт получать, ему вернут пустую страницу, так ещё и скажут, что там ещё есть

плохой вариант. надо запрос править, а не так отфильтровывать. а то страница списка сообщений может быть забита целиком системными и вот придёт фронт получать, ему вернут пустую страницу, так ещё и скажут, что там ещё есть
pasha1coil added 1 commit 2024-12-09 13:27:53 +00:00
added filter and add test with head common
All checks were successful
Lint / Lint (push) Successful in 2m21s
Details
4602fe3f72
skeris merged commit 4602fe3f72 into dev 2024-12-09 13:43:11 +00:00
skeris deleted branch system 2024-12-09 13:43:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed/Requested

сделал задачу - проставь этот статус

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed/Requested
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
pasha1coil
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PenaSide/heruvym#12
No description provided.
Delete Branch "system"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?